Update USAC #23078
Update USAC #23078
Conversation
|
@ivashmak friendly reminder |
Hi, sorry, I was busy with ICCV deadline. I fixed things you mentioned, thanks for the feedback. By the way, is there anything else I need to do regarding the multi-view calibration pull request? |
|
@ivashmak There are some memory corruption troubles reported by valgrind on Buildbot: https://pullrequest.opencv.org/buildbot/builders/4_x_valgrind-lin64-debug/builds/100019. Could you take a look on it? |
I had a look at this, but I was not able to recreate the same error on my local machine. I got a slightly different error in the same test related to 'Conditional jump or move depends on uninitialised value(s)'. I fixed it, so maybe it fixes that issue too. By the way, now I am getting strange error in automatic evaluation (in Docs): "error: Could not read a60b392" Do you know how I can fix it? |
| const Mat * points_mat; | ||
| const float * const points; |
| } | ||
| EXPECT_NE(roll_results_sum, 0); |
There was a problem hiding this comment.
It's not obvious that roll_results_sum += cv::norm(E1, E2, NORM_L1) != 0; happens even once. Previous line may hide actual behavior. We need to check amount of successful findEssentialMat at least.
There was a problem hiding this comment.
I have not written this test, and I do not think it is necessary. As I understand, it checks that output of RANSAC is not the same for 1 and 1000 iterations. However, given random behaviour of RANSAC it could happen that the output will be the same.
|
@ivashmak There is merge conflict. Please take a look. |
Merge usac to 5.x #24005 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake Base branch is PR #23979. Merging PR #23078, 23900 and PR #23806 to 5.x
Update USAC opencv#23078 ### Pull Request Readiness Checklist - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.