Get rid of unsafe raw pointers to Mat object in USAC #23806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivashmak Could you take a look on my proposal. |
asmorkalov
changed the title
asmorkalov
changed the title
|
It looks alright with me. Originally, I created those raw pointers, so I don't need to access them from the Mat container in each function at each iteration of RANSAC, but I guess this operation is fast enough anyway. |
asmorkalov
force-pushed
the
as/usac_drop_mat_ptr
branch
from
4a83058
to
27d3129
Compare
asmorkalov
changed the title
asmorkalov
changed the title
|
@mshabunin could you take a look too. |
mshabunin
reviewed
Jun 22, 2023
asmorkalov
force-pushed
the
as/usac_drop_mat_ptr
branch
from
27d3129
to
7590ba5
Compare
mshabunin
reviewed
Jun 22, 2023
asmorkalov
force-pushed
the
as/usac_drop_mat_ptr
branch
from
7590ba5
to
8302703
Compare
asmorkalov
force-pushed
the
as/usac_drop_mat_ptr
branch
from
8302703
to
0866a13
Compare
mshabunin
approved these changes
Jun 23, 2023
Merged
asmorkalov
pushed a commit
that referenced
this pull request
Jul 27, 2023
Merge usac to 5.x #24005 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake Base branch is PR #23979. Merging PR #23078, 23900 and PR #23806 to 5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #23078
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.