Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnn: fix overflow in sigmoid layer for 3.4 #23860

Merged
merged 1 commit into from
Jun 23, 2023
Merged

dnn: fix overflow in sigmoid layer for 3.4 #23860

merged 1 commit into from
Jun 23, 2023

Conversation

fengyuentau
Copy link
Member

@fengyuentau fengyuentau commented Jun 23, 2023 •
edited
Loading

Fixes #23850

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@fengyuentau fengyuentau added this to the 3.4.20 milestone Jun 23, 2023
@fengyuentau
Copy link
Member Author

@asmorkalov Should I close the other one #23857?

asmorkalov
asmorkalov approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit d9a5603 into opencv:3.4 Jun 23, 2023
15 checks passed
This was referenced Jun 23, 2023
Closed
Merged
@asmorkalov asmorkalov added the port/backport done Label for maintainers. Authors of PR can ignore this label Jun 25, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Merged
@fengyuentau fengyuentau deleted the fix_overflow_sigmoid_v3.4 branch November 21, 2023 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
bug category: dnn port/backport done Label for maintainers. Authors of PR can ignore this
Projects
None yet
Milestone
3.4.20
Development

Successfully merging this pull request may close these issues.
2 participants
@fengyuentau @asmorkalov