Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stereoRectify image boundaries. #24035

Merged
merged 1 commit into from Jul 27, 2023
Merged

Fix stereoRectify image boundaries. #24035

merged 1 commit into from Jul 27, 2023

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Jul 20, 2023 •
edited

This should have been fixed with #23304

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@opencv-alalek opencv-alalek added this to the 4.9.0 milestone Jul 20, 2023
@asmorkalov asmorkalov self-requested a review July 21, 2023 13:59
@vrabaud @asmorkalov
Fix stereoRectify image boundaries.
15815fb 
This should hav ebeen fixed with opencv#23304
asmorkalov
asmorkalov approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I added stronger check for result in tests.

@asmorkalov asmorkalov self-assigned this Jul 27, 2023
@asmorkalov asmorkalov merged commit 0323761 into opencv:4.x Jul 27, 2023
23 checks passed
@asmorkalov asmorkalov added the port to 5.x is needed Label for maintainers. Authors of PR can ignore this label Jul 28, 2023
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request Aug 2, 2023
@asmorkalov
Port stereoRectify grid fix opencv#24035.
357ae2e
@asmorkalov asmorkalov mentioned this pull request Aug 2, 2023
Merged
6 tasks
@asmorkalov asmorkalov added port/backport done Label for maintainers. Authors of PR can ignore this and removed port to 5.x is needed Label for maintainers. Authors of PR can ignore this labels Aug 2, 2023
asmorkalov added a commit to asmorkalov/opencv that referenced this pull request Aug 3, 2023
@asmorkalov
Port stereoRectify grid fix opencv#24035.
da28c62
asmorkalov added a commit that referenced this pull request Aug 4, 2023
@asmorkalov
Merge pull request #24096 from asmorkalov:as/vrabaud_calibration_port
fa91c14 
Port stereoRectify grid fix #24035
@asmorkalov asmorkalov mentioned this pull request Aug 7, 2023
Merged
@vrabaud vrabaud deleted the calibration branch December 5, 2023 12:31
vrabaud added a commit to vrabaud/opencv that referenced this pull request Dec 5, 2023
@vrabaud
Fix stereoRectify image boundaries again.
7f0a094 
This should have been fixed in opencv#24035
@vrabaud vrabaud mentioned this pull request Dec 5, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels
bug category: calib3d port/backport done Label for maintainers. Authors of PR can ignore this test
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vrabaud @asmorkalov @opencv-alalek