-
-
Notifications
You must be signed in to change notification settings - Fork 55.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added int support for OpenVINO dnn backend #25458
Added int support for OpenVINO dnn backend #25458
Conversation
|
Other failures are related to CI. I'll fix it and return back today. |
@@ -210,6 +210,9 @@ TEST_P(Test_TFLite, max_unpooling) | |||
} | |||
|
|||
TEST_P(Test_TFLite, EfficientDet_int8) { | |||
if (backend == DNN_BACKEND_INFERENCE_ENGINE_NGRAPH) | |||
applyTestTag(CV_TEST_TAG_DNN_SKIP_IE_NGRAPH); // TODO: fix this test for OpenVINO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did test work before the patch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test doesn't work in both 4.x and 5.x branches. Probably because I use the newest OpenVINO version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test definitely worked on 2023 release of OpenVINO. I will check 2024 version. I think ok to skip on this PR.
Backport: #25524 |
@dkurt could you take a look again? |
Modified dnn OpenVINO integration to support type inference and int operations.
Added OpenVINO support to Cast, CumSum, Expand, Gather, GatherElements, Scatter, ScatterND, Tile layers.
I tried to add Reduce layer, but looks like OpenVINO uses float values inside Reduce operation so it can't pass our int tests.
OpenVINO uses int32 precision for int64 operations, so I've modified input values for int64 tests when backend is OpenVINO.
OpenVINO has a strange behavior with custom layers and int64 values. After model compilation OpenVINO may change types, so the model can have different output type. That's why these tests were disabled:
Also these tests were temporary disabled, they didn't work on both 4.x and 5.x branches:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.