fix wrong conversion in estimateAffine2D* functions #8089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functions support points to have other datatypes than floats. * fix bug in coversion that overwrites src points with dst points
hrnr
force-pushed
the
estimate_convert_fix
branch
from
14af75b
to
9b85c53
Compare
|
I have restarted the build, because Win10 slave timed-out while connecting to github.com. |
test with integer points to cover conversion bugs.
hrnr
force-pushed
the
estimate_convert_fix
branch
from
9b85c53
to
4ee25c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug in estimateAffine2D* functions discovered by @phryniszak here http://answers.opencv.org/question/123476/estimateaffinepartial2d-and-estimateaffine2d/. Some discussion also happened on #6615.
estimateAffine2D* are supposed to work on int points, but due to bug in conversion code it returned always identity.
I have added new tests to cover this in the future.