Merge pull request #3321 from y-guyon:fix_get_subbox_chart_physical

Remove unused size of get_subbox_chart_physical()
opencv · Sep 5, 2022 · 467fd62 · 467fd62
2 parents 47bf66f + badef60
commit 467fd62
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/modules/mcc/src/checker_detector.cpp b/modules/mcc/src/checker_detector.cpp
@@ -802,8 +802,7 @@ void CCheckerDetectorImpl::
 
         // get physical char box model
         std::vector<cv::Point2f> chartPhy;
-        cv::Size size_box_phy;
-        get_subbox_chart_physical(points, chartPhy, size_box_phy);
+        get_subbox_chart_physical(points, chartPhy);
 
         // Find the perspective transformation that brings current chart to rectangular form
         Matx33f ccT = cv::getPerspectiveTransform(points, chartPhy);
@@ -1101,7 +1100,7 @@ void CCheckerDetectorImpl::
 }
 
 void CCheckerDetectorImpl::
-    get_subbox_chart_physical(const std::vector<cv::Point2f> &points, std::vector<cv::Point2f> &chartPhy, cv::Size &size)
+    get_subbox_chart_physical(const std::vector<cv::Point2f> &points, std::vector<cv::Point2f> &chartPhy)
 {
     float w, h;
     cv::Point2f v1 = points[1] - points[0];
@@ -1117,8 +1116,6 @@ void CCheckerDetectorImpl::
     chartPhy[1] = cv::Point2f(w, 0);
     chartPhy[2] = cv::Point2f(w, h);
     chartPhy[3] = cv::Point2f(0, h);
-
-    size = cv::Size((int)w, (int)h);
 }
 
 void CCheckerDetectorImpl::

diff --git a/modules/mcc/src/checker_detector.hpp b/modules/mcc/src/checker_detector.hpp
@@ -164,8 +164,7 @@ class CCheckerDetectorImpl : public CCheckerDetector
 private: // methods aux
     void get_subbox_chart_physical(
         const std::vector<cv::Point2f> &points,
-        std::vector<cv::Point2f> &chartPhy,
-        cv::Size &size);
+        std::vector<cv::Point2f> &chartPhy);
 
     void reduce_array(
         const std::vector<float> &x,