Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 16736 #2449

Merged
merged 3 commits into from
Mar 9, 2020
Merged

Issue 16736 #2449

merged 3 commits into from
Mar 9, 2020

Conversation

saskatchewancatch
Copy link
Contributor

@saskatchewancatch saskatchewancatch commented Mar 8, 2020

relates opencv/opencv#16736

Move SIFT out of non-free into free. I emailed David Lowe the author of SIFT and he mentioned that there is no possibility for patent extension. So this should be safe to go into free.

Build tested on Win64/VS15 with docs. SIFT tests complete when make is configured without non-free enabled.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under OpenCV (BSD) License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@AlucardNosferatu
Copy link

A big good news, looking forward to SIFT in 4.x

@ayush111111
Copy link

Thank you !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants