WIP [GSoC 2020] Macbeth Chart detection #2532

AjitPant · 2020-05-14T20:42:59Z

Merge with extra: opencv/opencv_extra#767

This is the pull request for the GSoC project "Macbeth Charts and AprilTags".

Currently it contains the port of the code from the ColorChecker Detection.

Link to trained model: https://drive.google.com/drive/folders/1JNWlmyfZKxiYQoYk6f0RzcGtHuiZq1Pz

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under OpenCV (BSD) License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
The PR is proposed to proper branch
There is reference to original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

modules/mcc/src/checker_detector.cpp

alalek

Thank you for the contribution!

Please take a look on coding style comments.

modules/mcc/CMakeLists.txt

modules/mcc/include/opencv2/mcc.hpp

modules/mcc/include/opencv2/mcc/checker_detector.hpp

alalek · 2020-06-25T08:33:43Z

modules/mcc/include/opencv2/mcc/checker_detector.hpp

+// #define SHOW_DEBUG_IMAGES
+namespace cv{
+namespace mcc{
+using namespace dnn;


using namespace is not allowed in public headers

dnn is used for Net. If I replaced using namespace by dnn::Net, python wrapper was giving the error that dnn_Net was not declared. I have added a typedef in misc/pyopencv_cchecker.hpp, but I am not sure if its the best way to solve it?

We not sure what the right way to do this? Is this correct @alalek ?

modules/mcc/include/opencv2/mcc/checker_detector.hpp

modules/mcc/src/bound_min.hpp

modules/mcc/src/charts.cpp

modules/mcc/src/checker_detector.cpp

modules/mcc/src/debug.cpp

modules/mcc/src/dictionary.hpp

garybradski · 2020-06-25T23:03:35Z

I tested that the example_mcc_chart_detection runs on video and on camera (and also added doc of what the -t and -ci numbers are)

garybradski · 2020-06-25T23:07:50Z

It would be nice to add in an option -imgs that took a list, say one per line of:
path/image
path/image
...
and the program ran on those, maybe space to continue, esq to quit so that one could judge how accurate it is at finding things.

garybradski · 2020-06-25T23:14:05Z

This performs OK, it's suprisingly slow -- much slower than my python. I found centers by detecting canny edges, doing a distance transform, thresholding that, flood filling from those threshold areas and looking for quad contours.

modules/mcc/src/wiener_filter.hpp

vpisarev · 2020-07-15T15:45:57Z

@AjitPant, @garybradski, it looks like at least some parts of the detector are taken from https://github.com/pedrodiamel/colorchecker-detection.

We must put the corresponding notice about it, otherwise this patch will violate the license and cannot be included. If the patch cannot be included it means that at least a half of GSoC, related to macbeth chart detector, is not done.

mayankgrd · 2020-07-21T16:56:44Z

Hi friends,
Wanted to know the status of this project ?

…two orders of magnitude, perhaps)

catree · 2020-07-25T20:39:09Z

(Not related to this PR)

An interesting talk: Understanding Color and the In-Camera Image Processing Pipeline for Computer Vision, Michael S. Brown @ ICCV 2019

AjitPant · 2020-07-28T22:15:46Z

@vpisarev I have added the Licence from the original repo on top of all source files.

AjitPant · 2020-07-28T22:22:25Z

@mayankgrd The code for the detector is almost done. It can detect three different types of chart at the moment. But it will take some time before it gets merged. If you want to use it before it gets merged, you can clone the mcc branch from AjitPant/opencv_contrib.

garybradski · 2020-07-29T17:06:31Z

@AjitPant, @garybradski, it looks like at least some parts of the detector are taken from https://github.com/pedrodiamel/colorchecker-detection.

We must put the corresponding notice about it, otherwise this patch will violate the license and cannot be included. If the patch cannot be included it means that at least a half of GSoC, related to macbeth chart detector, is not done.

I think the licenses are put in now

garybradski · 2020-08-01T07:07:45Z

This performs OK, it's suprisingly slow -- much slower than my python. I found centers by detecting canny edges, doing a distance transform, thresholding that, flood filling from those threshold areas and looking for quad contours.

OK, thanks to Vadim's help, this issue is resolved -- it now runs at frame rate.

garybradski · 2020-08-01T07:09:04Z

It would be nice to add in an option -imgs that took a list, say one per line of:
path/image
path/image
...
and the program ran on those, maybe space to continue, esq to quit so that one could judge how accurate it is at finding things.

This isn't resolved, but it was just a suggestion that is trivial to change later or just not do it. It shouldn't hold up the merge of the pull request.

garybradski · 2020-08-01T07:09:58Z

@AjitPant, @garybradski, it looks like at least some parts of the detector are taken from https://github.com/pedrodiamel/colorchecker-detection.
We must put the corresponding notice about it, otherwise this patch will violate the license and cannot be included. If the patch cannot be included it means that at least a half of GSoC, related to macbeth chart detector, is not done.

I think the licenses are put in now

This is now resolved.

vpisarev · 2020-08-01T14:16:29Z

good to go, in my opinion 👍

vpisarev · 2020-08-01T14:17:29Z

@mshabunin, if you don't have objections, can we merge it in? I tested it on my machine, works well. The licenses are in place now.

AjitPant added 11 commits May 15, 2020 00:52

First commit

5b04e38

Updated mcc

08f3626

Fixed build warnings.

8526e75

Fixed warnings v2

ed30d5a

Added support for providing regions to look for the chart

c0d2d42

Added the neural network based detector

5550b91

Added Documentation and tests

7056e67

Fixed Warnings

1b06a35

Fixed test failure

2e2cf05

Fixed warnings v2

b6bede1

Fix Warning attemp 3

afeabd2

bhack reviewed Jun 19, 2020

View reviewed changes

modules/mcc/src/checker_detector.cpp Outdated Show resolved Hide resolved

AjitPant added 3 commits June 20, 2020 04:29

Replaced size_t by int to fix warning

f097647

fixed one more

0aef66e

Fixed a size_t

ad89046

alalek reviewed Jun 25, 2020

View reviewed changes

AjitPant and others added 3 commits June 25, 2020 23:44

Fixed some bugs

68ca28a

Modified the private interface a bit

b3d427f

Just adding doc of what -t and -ci numbers are

46efd14

mshabunin added the GSoC label Jun 29, 2020

vpisarev reviewed Jul 15, 2020

View reviewed changes

modules/mcc/src/wiener_filter.hpp Show resolved Hide resolved

significantly improved performance of the macbeth chart detector (by …

b01abee

…two orders of magnitude, perhaps)

AjitPant added 2 commits July 29, 2020 01:41

Fixed the suggested changes.

dd6e665

Removed imcodes from precomp

f58aa0b

AjitPant added 2 commits July 29, 2020 03:07

Fixed warnings and namespace issue

a47a3e4

Replaced occurance of Matx33f by InputArray

953f7c4

garybradski approved these changes Jul 29, 2020

View reviewed changes

vpisarev self-requested a review August 1, 2020 14:15

vpisarev approved these changes Aug 1, 2020

View reviewed changes

vpisarev assigned mshabunin Aug 1, 2020

mshabunin approved these changes Aug 3, 2020

View reviewed changes

mshabunin merged commit 2554f41 into opencv:master Aug 3, 2020

alalek assigned vpisarev and unassigned mshabunin Aug 3, 2020

stereomatchingkiss mentioned this pull request Mar 22, 2022

Color checker detector cannot to detect the board #3210

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP [GSoC 2020] Macbeth Chart detection #2532

WIP [GSoC 2020] Macbeth Chart detection #2532

AjitPant commented May 14, 2020 •

edited by garybradski

Loading

alalek left a comment

alalek Jun 25, 2020

AjitPant Jul 28, 2020

garybradski Jul 29, 2020

garybradski commented Jun 25, 2020

garybradski commented Jun 25, 2020

garybradski commented Jun 25, 2020

vpisarev commented Jul 15, 2020

mayankgrd commented Jul 21, 2020

catree commented Jul 25, 2020

AjitPant commented Jul 28, 2020

AjitPant commented Jul 28, 2020

garybradski commented Jul 29, 2020

garybradski commented Aug 1, 2020

garybradski commented Aug 1, 2020

garybradski commented Aug 1, 2020

vpisarev commented Aug 1, 2020

vpisarev commented Aug 1, 2020

WIP [GSoC 2020] Macbeth Chart detection #2532

WIP [GSoC 2020] Macbeth Chart detection #2532

Conversation

AjitPant commented May 14, 2020 • edited by garybradski Loading

Pull Request Readiness Checklist

alalek left a comment

Choose a reason for hiding this comment

alalek Jun 25, 2020

Choose a reason for hiding this comment

AjitPant Jul 28, 2020

Choose a reason for hiding this comment

garybradski Jul 29, 2020

Choose a reason for hiding this comment

garybradski commented Jun 25, 2020

garybradski commented Jun 25, 2020

garybradski commented Jun 25, 2020

vpisarev commented Jul 15, 2020

mayankgrd commented Jul 21, 2020

catree commented Jul 25, 2020

AjitPant commented Jul 28, 2020

AjitPant commented Jul 28, 2020

garybradski commented Jul 29, 2020

garybradski commented Aug 1, 2020

garybradski commented Aug 1, 2020

garybradski commented Aug 1, 2020

vpisarev commented Aug 1, 2020

vpisarev commented Aug 1, 2020

AjitPant commented May 14, 2020 •

edited by garybradski

Loading