Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP [GSoC 2020] Macbeth Chart detection #2532
WIP [GSoC 2020] Macbeth Chart detection #2532
Changes from 17 commits
5b04e38
08f3626
8526e75
ed30d5a
c0d2d42
5550b91
7056e67
1b06a35
2e2cf05
b6bede1
afeabd2
f097647
0aef66e
ad89046
68ca28a
b3d427f
46efd14
b01abee
dd6e665
f58aa0b
a47a3e4
953f7c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using namespace
is not allowed in public headersThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dnn is used for Net. If I replaced using namespace by dnn::Net, python wrapper was giving the error that dnn_Net was not declared. I have added a typedef in misc/pyopencv_cchecker.hpp, but I am not sure if its the best way to solve it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We not sure what the right way to do this? Is this correct @alalek ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"const reference" for
std::vector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Earlier I was adding an element corresponding to full image if the original vector was emtpy, so couldn't use const. Now I have replaced it by two overloaded functions, with const reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alalek Is over loading a good solution to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal implementation details should not be exposed in public headers.
Public API should contain interfaces, with several "get"/"set" virtual methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Should I do the same for DetectorParameters also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alalek This is fixed, but is the DetectorParameters correct also (no functions are in this, just variables) ... so this is resolved, correct?