Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libSGM into cudastereo #2772

Conversation

sotsuka-fixstars
Copy link
Contributor

@sotsuka-fixstars sotsuka-fixstars commented Dec 4, 2020

Merge with extra: opencv/opencv_extra#826

We are developers of libSGM, a CUDA implementation of Semi-Global Matching.
This PR adds libSGM into cudastereo module.

The orginal algorithm is described in [1].
For matching cost, the center-symmetric census transform [2] is used.

[1] Heiko Hirschmuller. Stereo processing by semiglobal matching and mutual information. Pattern Analysis and Machine Intelligence, IEEE Transactions on, 30(2):328–341, 2008.
[2] Robert Spangenberg, Tobias Langner, and Raúl Rojas. Weighted semi-global matching and center-symmetric census transform for robust driver assistance. In Computer Analysis of Images and Patterns, pages 34–41. Springer Berlin Heidelberg, 2013.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented
  • and sample code can be built with the project CMake
force_builders=Custom
buildworker:Custom=linux-4
build_image:Custom=ubuntu-cuda:16.04

Copy link
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for contribution 👍

@opencv-pushbot opencv-pushbot merged commit dda1f3d into opencv:master Dec 11, 2020
@Hunkzer
Copy link

Hunkzer commented Jan 4, 2021

Hi. Great implementation. Will this be available in opencv 3 also?

@alalek
Copy link
Member

alalek commented Jan 4, 2021

opencv 3

OpenCV 3.x is in the maintenance mode.
New functionality should not be added there.

@alalek alalek mentioned this pull request Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants