Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor SQL conditional translation #520

Merged
merged 1 commit into from
May 16, 2024
Merged

refactor SQL conditional translation #520

merged 1 commit into from
May 16, 2024

Conversation

pcoccoli
Copy link
Collaborator

Make _render_comp and _render_multi_comp methods of SqlTranslator so that SQLAlchemyTranslator can use them.

@pcoccoli pcoccoli requested a review from subbyte May 15, 2024 18:00
subbyte
subbyte approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@subbyte subbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pcoccoli pcoccoli merged commit 0db6807 into develop May 16, 2024
27 checks passed
@pcoccoli pcoccoli deleted the refactor_cond branch May 16, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subbyte subbyte subbyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcoccoli @subbyte