Handle empty config file (#1604)

* Fix typo in comments.

* Parse blank config files as ini files.

* Update smells_like_ini test.

* Update whats_new.rst

datacube/cfg/api.py

@@ -104,7 +104,7 @@ def __init__(
         self.allow_envvar_overrides = not text and not raw_dict
 
         if not raw_dict and not text:
-            # No explict config passed in.  Check for ODC_CONFIG environmnet variables
+            # No explict config passed in.  Check for ODC_CONFIG environment variables
             if os.environ.get("ODC_CONFIG"):
                 text = os.environ["ODC_CONFIG"]
             else:

datacube/cfg/utils.py

@@ -54,5 +54,5 @@ def smells_like_ini(cfg_text: str):
             return True
         else:
             return False
-    # Doesn't smell like anything
-    return False
+    # Empty file - parse as ini so we end up with the right high level structure at least
+    return True

docs/about/whats_new.rst

@@ -8,6 +8,8 @@ What's New
 v1.9.next
 =========
 
+- Ensure config API works with a blank config/empty file. (:pull:`1604`)
+
 v1.9.0-rc8 (18th June 2024)
 ===========================
 

tests/test_cfg.py

@@ -45,7 +45,7 @@ def test_smells_like_ini():
 aasdfer\\faw043[]]][""")
 
     # Pure white space
-    assert not smells_like_ini("   \n  \n    \n \n  \t  \t  \n   \n")
+    assert smells_like_ini("   \n  \n    \n \n  \t  \t  \n   \n")
 
 
 @pytest.fixture