Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty config file #1604

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Handle empty config file #1604

merged 4 commits into from
Jun 21, 2024

Conversation

SpacemanPaul
Copy link
Contributor

Reason for this pull request

An empty/blank/pure white space config file triggered an error.

Proposed changes

  • Parse empty/blank/pure white space config files as INI files instead of YAML files. This results in the correct high level structure being returned to the Config API (i.e. an empty dictionary instead of None).

  • Closes Empty ~/.datacube.conf causes errors #1603

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.43%. Comparing base (3df96cd) to head (c32c1bc).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop-1.9    #1604   +/-   ##
============================================
  Coverage        85.43%   85.43%           
============================================
  Files              140      140           
  Lines            15496    15496           
============================================
  Hits             13239    13239           
  Misses            2257     2257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul merged commit 16cc0ea into develop-1.9 Jun 21, 2024
30 checks passed
@SpacemanPaul SpacemanPaul deleted the handle_empty_config_file branch June 21, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants