Ensure that botocore/boto3 dependency is optional #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps that needed `replicas` and `interactive` are no longer in the repo. Also adding more dependencies that were missing but were pulled in because of other dependencies (pandas is used in datacube code directly, but is also pulled in by xarray).
Datacube does NOT declare dependency on botocore by default, it is currently behind `s3` feature flag, so code should not import anything from botocore or utils.aws at module level.
boto is not a default dependency, so should not be imported at module level without import guards
Codecov Report
@@ Coverage Diff @@
## develop #1174 +/- ##
===========================================
- Coverage 93.75% 93.74% -0.01%
===========================================
Files 102 102
Lines 10347 10347
===========================================
- Hits 9701 9700 -1
- Misses 646 647 +1
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
datacubecan run in an environment without botocore librariesProposed changes
Remove no longer used extras flags:
interactiveandreplicasAdd dependencies that are used directly but installed indirectly (
pandas,botocore,kombu)Update test docker
Add guards to
test_3dtestCloses Missing required dependencies in default install #1172
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes