Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that botocore/boto3 dependency is optional #1174

Merged
merged 5 commits into from Aug 11, 2021
Merged

Ensure that botocore/boto3 dependency is optional #1174

merged 5 commits into from Aug 11, 2021

Commits on Aug 10, 2021

  1. Cleanup extras that no longer apply 

    Apps that needed `replicas` and `interactive` are no longer in the repo. Also
adding more dependencies that were missing but were pulled in because of other
dependencies (pandas is used in datacube code directly, but is also pulled in by
xarray).
    @Kirill888
    Kirill888 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    736b41c View commit details
    Browse the repository at this point in the history

  2. Make botocore dependency optional in utils.dask (#1172) 

    Datacube does NOT declare dependency on botocore by default, it is currently
behind `s3` feature flag, so code should not import anything from botocore or
utils.aws at module level.
    @Kirill888
    Kirill888 committed Aug 10, 2021
    Configuration menu
    Copy the full SHA
    42e0a78 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2021

  1. Remove unneeded dependencies from test docker and other cleanup

    @Kirill888
    Kirill888 committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    3080f32 View commit details
    Browse the repository at this point in the history

  2. Skip 3d read tests if test drivers are not installed

    @Kirill888
    Kirill888 committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    18f7409 View commit details
    Browse the repository at this point in the history

  3. Only import from utils.aws. when requested (#1172) 

    boto is not a default dependency, so should not be imported at module level
without import guards
    @Kirill888
    Kirill888 committed Aug 11, 2021
    Configuration menu
    Copy the full SHA
    eead051 View commit details
    Browse the repository at this point in the history