Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index api consistency #1234

Merged
merged 4 commits into from Feb 22, 2022
Merged

Index api consistency #1234

merged 4 commits into from Feb 22, 2022

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Feb 22, 2022

Reason for this pull request

  1. API inconsistencies were identified during work on Abstract Base Classes for index backend interface(s). #1226.
  2. redis-server was left out of Docker build in Migrate docker image off geobase to osgeo/gdal #1233, bypassing celery tests.

Proposed changes

  1. Regularise API inconsistencies
  2. Add redis-server to docker image to allow celery tests to run

Note: The celery integration depends on ancient and security-compromised version of celery. The general consensus seems to be that it is useless and nobody uses it, but I need to consult more widely before removing it all together.

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #1234 (b9681a6) into develop (c1f20f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1234   +/-   ##
========================================
  Coverage    92.71%   92.71%           
========================================
  Files          103      103           
  Lines        10595    10598    +3     
========================================
+ Hits          9823     9826    +3     
  Misses         772      772           
Impacted Files Coverage Δ
datacube/index/abstract.py 94.89% <100.00%> (ø)
datacube/index/postgres/_datasets.py 94.84% <100.00%> (+0.02%) ⬆️
datacube/scripts/dataset.py 88.23% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a01472b...b9681a6. Read the comment docs.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review February 22, 2022 06:09
@SpacemanPaul SpacemanPaul merged commit 38a314a into develop Feb 22, 2022
@SpacemanPaul SpacemanPaul deleted the index_api_consistency branch February 22, 2022 23:16
Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants