Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate docker image off geobase to osgeo/gdal #1233

Merged
merged 5 commits into from Feb 21, 2022
Merged

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Feb 21, 2022

Reason for this pull request

Docker image used for testing was built on datacube/geobase which is now deprecated.

Proposed changes

New Docker build based on osgeo/gdal. Simple single-stage docker build, could be further optimised but seems sufficient for CI testing and dev purposes.

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #1233 (e5670c6) into develop (0fc51cd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1233   +/-   ##
========================================
  Coverage    93.79%   93.79%           
========================================
  Files          103      103           
  Lines        10597    10597           
========================================
  Hits          9939     9939           
  Misses         658      658           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1898d...e5670c6. Read the comment docs.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review February 21, 2022 01:09
Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change needed really is to pin the FROM docker image version.

docker/Dockerfile Outdated Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Show resolved Hide resolved
Copy link
Contributor

@alexgleith alexgleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@SpacemanPaul SpacemanPaul merged commit 370f4ba into develop Feb 21, 2022
@SpacemanPaul SpacemanPaul deleted the docker_to_osgeo branch February 21, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Github test environment off geobase
3 participants