tweak list_products to consider load_hints #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ariana-B
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1535 +/- ##
===========================================
- Coverage 91.79% 91.77% -0.02%
===========================================
Files 132 132
Lines 14624 14631 +7
===========================================
+ Hits 13424 13428 +4
- Misses 1200 1203 +3 ☔ View full report in Codecov by Sentry. |
SpacemanPaul
approved these changes
Jan 17, 2024
SpacemanPaul
pushed a commit
that referenced
this pull request
Jan 17, 2024
* tweak list_products to check for crs and resolution in load_hints * update whats_new * get osgeo/gdal from ghcr --------- Authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au>
2 tasks
SpacemanPaul
added a commit
that referenced
this pull request
Jan 18, 2024
* New MDT get_with_fields() method. * Product resource cleanup (including methods moving in and out) see EP13. * Get tests passing as they are. * Porting tests hopefully keeping coverage. * More test porting and migrating internal usages of deprecated/moved methods. * What's new * What's new - update PR number * Minor change to whats_new - mostly to kick off checks again. * Lintage. * tweak list_products to consider load_hints (#1535) * tweak list_products to check for crs and resolution in load_hints * update whats_new * get osgeo/gdal from ghcr --------- Authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au> * Fix query API test fixture. * Fix virtual product test fixture. * Nice cleanup - thanks @Ariana-B --------- Co-authored-by: Ariana-B <40238244+ariana-b@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
list_productswould always getcrsandresolutionfromgrid_speceven ifdefault_crsordefault_resolutionis not None or ifcrsandresolutionwere defined viaload_hints.Proposed changes
Return default values if present
Don't ignore
load_hintsif notCloses list_products ignores information in load hints #1531
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1535.org.readthedocs.build/en/1535/