New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP13 product/metadata type resource updates #1536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tweak list_products to check for crs and resolution in load_hints * update whats_new * get osgeo/gdal from ghcr --------- Authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1536 +/- ##
===============================================
- Coverage 85.33% 85.30% -0.04%
===============================================
Files 140 140
Lines 15018 14994 -24
===============================================
- Hits 12815 12790 -25
- Misses 2203 2204 +1 ☔ View full report in Codecov by Sentry. |
Ariana-B
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Changes to the
MetadataTypeResource
andProductResource
APIs, as proposed in EP13.Proposed changes
New
products.get_with_types()
methodNew
metadata.get_with_fields()
methodExisting
products.get_with_fields()
method implemented in the base class using the above new methods.get_field_names()
moved from DatasetResource to ProductResource.datasets.get_field_names()
is now implemented in the base class as a deprecated wrapper method toproducts.get_field_names()
.Changes to tests and test fixtures for API changes.
Cherry pick tweak list_products to consider load_hints #1535, mostly for the GHA container repository fix.
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes