Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP13 product/metadata type resource updates #1536

Merged
merged 13 commits into from Jan 18, 2024

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Jan 17, 2024

Reason for this pull request

Changes to the MetadataTypeResource and ProductResource APIs, as proposed in EP13.

Proposed changes

  • New products.get_with_types() method

  • New metadata.get_with_fields() method

  • Existing products.get_with_fields() method implemented in the base class using the above new methods.

  • get_field_names() moved from DatasetResource to ProductResource. datasets.get_field_names() is now implemented in the base class as a deprecated wrapper method to products.get_field_names().

  • Changes to tests and test fixtures for API changes.

  • Cherry pick tweak list_products to consider load_hints #1535, mostly for the GHA container repository fix.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

@SpacemanPaul SpacemanPaul changed the base branch from develop to develop-1.9 January 17, 2024 05:23
SpacemanPaul and others added 5 commits January 17, 2024 16:25
* tweak list_products to check for crs and resolution in load_hints

* update whats_new

* get osgeo/gdal from ghcr

---------

Authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au>
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (2671f2c) 85.33% compared to head (14de9a9) 85.30%.

Files Patch % Lines
datacube/api/core.py 0.00% 7 Missing ⚠️
datacube/index/abstract.py 91.66% 2 Missing ⚠️
datacube/model/__init__.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1536      +/-   ##
===============================================
- Coverage        85.33%   85.30%   -0.04%     
===============================================
  Files              140      140              
  Lines            15018    14994      -24     
===============================================
- Hits             12815    12790      -25     
- Misses            2203     2204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Ariana-B Ariana-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

datacube/index/abstract.py Outdated Show resolved Hide resolved
@SpacemanPaul SpacemanPaul merged commit bb42559 into develop-1.9 Jan 18, 2024
28 checks passed
@SpacemanPaul SpacemanPaul deleted the ep13-prod-mdt-resource-updates branch January 18, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants