Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov action and update whats_new.rst #1554

Merged
merged 1 commit into from Feb 21, 2024
Merged

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Feb 21, 2024

Reason for this pull request

Codecov github action was broken by #1542. This PR fixes it.

Note that this change is applied for develop-1.9 in #1553

Proposed changes

  • Pass Codecov auth token as repo secret, as required by codecov-action@v4

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1554.org.readthedocs.build/en/1554/

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3243808) 91.77% compared to head (959207b) 91.77%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1554   +/-   ##
========================================
  Coverage    91.77%   91.77%           
========================================
  Files          132      132           
  Lines        14631    14631           
========================================
  Hits         13428    13428           
  Misses        1203     1203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@omad omad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@omad omad merged commit bfb8417 into develop Feb 21, 2024
29 checks passed
@omad omad deleted the fix_codecov_in_develop branch February 21, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants