Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8 to 1.9 cherry picks #1565

Merged
merged 15 commits into from
Mar 18, 2024
Merged

1.8 to 1.9 cherry picks #1565

merged 15 commits into from
Mar 18, 2024

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Mar 18, 2024

Reason for this pull request

Porting recent PRs to develop into develop-1.9.

Proposed changes

Note also that the changes applied to develop in #1554 have already been applied to develop-1.9 as part of #1557.

  • [] Tests added / passed
  • [] Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.59%. Comparing base (ea3068d) to head (c97e4ea).

Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1565      +/-   ##
===============================================
+ Coverage        85.57%   85.59%   +0.01%     
===============================================
  Files              140      140              
  Lines            15366    15366              
===============================================
+ Hits             13150    13152       +2     
+ Misses            2216     2214       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review March 18, 2024 03:24
Copy link
Contributor

@Ariana-B Ariana-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SpacemanPaul SpacemanPaul merged commit 7af7e49 into develop-1.9 Mar 18, 2024
30 checks passed
@SpacemanPaul SpacemanPaul deleted the 1.8-to-1.9-cherry-picks branch March 18, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants