Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search returning new args #1557

Merged
merged 15 commits into from Mar 4, 2024
Merged

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Feb 27, 2024

Reason for this pull request

Add custom_offsets and order_by arguments to search_returning().

(N.B. order_by is still unimplemented)

See EP-13.

N.B. originally includes the changes in #1553 - that PR has been dropped and this one updated to remove those changes.

Proposed changes

  • Add both args to abstract base class and implementations

  • Implement custom_offsets argument in all index drivers.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.62%. Comparing base (2ee5434) to head (55c5d89).
Report is 5 commits behind head on develop-1.9.

Files Patch % Lines
datacube/index/postgres/_datasets.py 93.33% 2 Missing ⚠️
datacube/index/memory/_datasets.py 93.75% 1 Missing ⚠️
datacube/index/postgis/_datasets.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1557      +/-   ##
===============================================
- Coverage        85.65%   85.62%   -0.03%     
===============================================
  Files              140      140              
  Lines            15175    15299     +124     
===============================================
+ Hits             12998    13100     +102     
- Misses            2177     2199      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SpacemanPaul SpacemanPaul marked this pull request as ready for review February 27, 2024 03:51
datacube/drivers/postgis/_api.py Outdated Show resolved Hide resolved
datacube/index/memory/_datasets.py Outdated Show resolved Hide resolved
datacube/index/memory/_datasets.py Outdated Show resolved Hide resolved
@SpacemanPaul SpacemanPaul merged commit 5b0d0c7 into develop-1.9 Mar 4, 2024
28 checks passed
@SpacemanPaul SpacemanPaul deleted the search_returning_new_args branch March 4, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants