New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search returning new args #1557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1557 +/- ##
===============================================
- Coverage 85.65% 85.62% -0.03%
===============================================
Files 140 140
Lines 15175 15299 +124
===============================================
+ Hits 12998 13100 +102
- Misses 2177 2199 +22 ☔ View full report in Codecov by Sentry. |
SpacemanPaul
force-pushed
the
search_returning_new_args
branch
from
February 27, 2024 05:31
8ef7506
to
a346f23
Compare
Ariana-B
reviewed
Feb 28, 2024
SpacemanPaul
force-pushed
the
search_returning_new_args
branch
from
February 29, 2024 22:49
a346f23
to
cf35ea0
Compare
for more information, see https://pre-commit.ci
…search_returning_new_args_redo
Ariana-B
reviewed
Mar 1, 2024
Ariana-B
reviewed
Mar 4, 2024
Ariana-B
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Add
custom_offsets
andorder_by
arguments tosearch_returning()
.(N.B.
order_by
is still unimplemented)See EP-13.
N.B. originally includes the changes in #1553 - that PR has been dropped and this one updated to remove those changes.
Proposed changes
Add both args to abstract base class and implementations
Implement
custom_offsets
argument in all index drivers.Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes