Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias support for virtual products #612

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Conversation

uchchwhash
Copy link
Member

Reason for this pull request

  • Add alias support for virtual products
  • Fix geopolygon bug

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #612 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #612      +/-   ##
===========================================
+ Coverage    86.41%   86.44%   +0.02%     
===========================================
  Files           84       84              
  Lines         8100     8101       +1     
===========================================
+ Hits          7000     7003       +3     
+ Misses        1100     1098       -2
Impacted Files Coverage Δ
datacube/virtual/utils.py 78.37% <ø> (-1.11%) ⬇️
datacube/virtual/impl.py 89.75% <100%> (+0.12%) ⬆️
datacube/model/__init__.py 86.95% <0%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27dce16...143e6cb. Read the comment docs.

@ashoka1234
Copy link
Contributor

Looks good.

@ashoka1234 ashoka1234 closed this Dec 6, 2018
@ashoka1234 ashoka1234 reopened this Dec 6, 2018
Copy link
Contributor

@ashoka1234 ashoka1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mergify mergify bot merged commit 83bae20 into develop Dec 6, 2018
@delete-merged-branch delete-merged-branch bot deleted the virtual-product-aliases branch December 6, 2018 03:50
@coveralls
Copy link

coveralls commented Dec 8, 2018

Coverage Status

Coverage increased (+0.03%) to 86.421% when pulling 143e6cb on virtual-product-aliases into 27dce16 on develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants