Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual product formula transformation #699

Merged
merged 2 commits into from
Apr 11, 2019

Conversation

uchchwhash
Copy link
Member

Reason for this pull request

Add a useful transformation formula that supports Python's expression language
to do band maths in virtual products.

Proposed changes

  • Add formula transformation
  • Add simple test
  • Update documentation to mention the transformation
  • Add lark-parser as a dependency

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #699 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #699      +/-   ##
===========================================
+ Coverage    88.51%   88.56%   +0.05%     
===========================================
  Files          105      105              
  Lines         9261     9302      +41     
===========================================
+ Hits          8197     8238      +41     
  Misses        1064     1064
Impacted Files Coverage Δ
datacube/virtual/__init__.py 80% <100%> (ø) ⬆️
datacube/virtual/transformations.py 87.41% <100%> (+4.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db97e2c...65b3a04. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 88.519% when pulling 65b3a04 on virtual-product-formula-transformation into db97e2c on develop.

Copy link
Contributor

@andrewdhicks andrewdhicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very clean implementation! Nice work!

@mergify mergify bot merged commit c99c847 into develop Apr 11, 2019
@mergify mergify bot deleted the virtual-product-formula-transformation branch April 11, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants