Add schema filtering for columns, pks, fks, enums, unique keys #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyNenashev
requested changes
May 1, 2024
Comment on lines
121
to
126
| return [ | ||
| PrimaryKey(*raw) | ||
| for raw in self.execute( | ||
| self.pks_query(self.get_filtered_schema_names_str), cur | ||
| ) | ||
| ] |
There was a problem hiding this comment.
if we cannot use list comprehension inline let's decompose it then for readability
Suggested change
| return [ | |
| PrimaryKey(*raw) | |
| for raw in self.execute( | |
| self.pks_query(self.get_filtered_schema_names_str), cur | |
| ) | |
| ] | |
| raw_data = self.execute( | |
| self.pks_query(self.get_filtered_schema_names_str), cur | |
| ) | |
| return [PrimaryKey(*raw) for raw in raw_data] |
AndreyNenashev
approved these changes
May 1, 2024
|
Is there any documentation on how to implement this? I know how to filter schemas but no columns and so on. Thanks for this addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.