Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sync up to upstream commit for v0.11.1 #108

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

israel-hdez
Copy link

@israel-hdez israel-hdez commented Oct 17, 2023

Testing

Based on instructions of the following PR: #93:

A simple sanity check should be OK.

Checkout this PR:

  1. Clone the repo: git clone https://github.com/opendatahub-io/kserve.git && cd kserve
  2. Fetch the PR: git fetch origin pull/108/merge:pr-108
  3. Checkout the code: git checkout pr-108

On a clean OpenShift cluster, and given you have the code of this PR checked out:

  1. Deploy ServiceMesh. Run: test/scripts/openshift-ci/deploy.ossm.sh
  2. Deploy Serverless. Run: test/scripts/openshift-ci/deploy.serverless.sh
  3. Deploy KServe:
oc new-project kserve
oc label namespace kserve testing.kserve.io/add-to-mesh=true
kustomize build config/overlays/odh | \
  sed "s|kserve/storage-initializer:latest|quay.io/opendatahub/kserve-storage-initializer:pr-108|" | \
  sed "s|kserve/agent:latest|quay.io/opendatahub/kserve-agent:pr-108|" | \
  sed "s|kserve/router:latest|quay.io/opendatahub/kserve-router:pr-108|" | \
  sed "s|kserve/kserve-controller:latest|quay.io/opendatahub/kserve-controller:pr-108|" | \
  oc apply -f -
  1. Deploy a test model:
oc new-project kserve-test
oc label namespace kserve-test testing.kserve.io/add-to-mesh=true
sed 's/ClusterServingRuntime/ServingRuntime/' config/runtimes/kserve-mlserver.yaml | \
  sed "s|mlserver:replace|docker.io/seldonio/mlserver:1.3.2|" | \
  oc apply -f -
cat <<EOF | oc apply -f -
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "sklearn-irisv2"
  annotations:
    serving.knative.openshift.io/enablePassthrough: "true"
    sidecar.istio.io/inject: "true"
    sidecar.istio.io/rewriteAppHTTPProbers: "true"
spec:
  predictor:
    model:
      modelFormat:
        name: sklearn
      runtime: kserve-mlserver
      storageUri: "gs://seldon-models/sklearn/mms/lr_model"
EOF
  1. Check that the model replies correctly:
ENDPOINT=$(oc get ksvc sklearn-irisv2-predictor -o jsonpath='{.status.url}')
curl -kv -H "Content-Type: application/json" -d '{"inputs": [{"name": "input-0","shape": [2, 4],"datatype": "FP32","data": [[6.8, 2.8, 4.8, 1.4],[6.0, 3.4, 4.5, 1.6]]}]}' $ENDPOINT/v2/models/sklearn-irisv2/infer

If you get a reply, it should all be running OK.

sivanantha321 and others added 6 commits September 13, 2023 05:41
Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
* Fixed torchserve e2e test.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Upgraded torchserve-kfs image to 0.8.2

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Fixed torchserve transformer e2e.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

* Set PROTOCOL_VERSION env based on protocol version spec.

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>

---------

Signed-off-by: Andrews Arokiam <andrews.arokiam@ideas2it.com>
* Refactoring common code to a function

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Added e2e test cases for splitter nodes

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Fixed linting errors

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* Minor refactoring for error message

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

---------

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
* Move storage uri check from validator to pod mutator

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Move storage uri validation to controller

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix test

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

* Fix tests, add comments, and remove model transition status

Signed-off-by: Jin Dong <jdong183@bloomberg.net>

---------

Signed-off-by: Jin Dong <jdong183@bloomberg.net>
* Bumping version for 0.11.1

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>

* add back kustomize

* Update VERSION

---------

Signed-off-by: Rachit Chauhan <rachitchauhan43@gmail.com>
Co-authored-by: Dan Sun <dsun20@bloomberg.net>
@israel-hdez
Copy link
Author

/retest

1 similar comment
@israel-hdez
Copy link
Author

/retest

Copy link

@Jooho Jooho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 8ecdb2d into opendatahub-io:master Oct 19, 2023
27 checks passed
@israel-hdez israel-hdez deleted the o-upsync-v0111 branch October 20, 2023 16:49
Jooho pushed a commit to Jooho/kserve that referenced this pull request Jan 11, 2024
…-script

utils: prevent convert.py from erroring out
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants