Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase memory limit of kserve-controller pod #261

Conversation

israel-hdez
Copy link

What this PR does / why we need it:

The increased memory limit is for the controller pod to work normally in clusters having 9k+ secrets.

Which issue(s) this PR fixes

Related to https://issues.redhat.com/browse/RHOAIENG-3996

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

With KServe deployed:

The increased memory limit is for the controller pod to work normally in clusters having 9k+ secrets.

Related https://issues.redhat.com/browse/RHOAIENG-3996

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@Jooho
Copy link

Jooho commented Mar 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 1, 2024
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [israel-hdez,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link
Author

/override ci/prow/e2e-slow ci/prow/e2e-fast

Copy link

openshift-ci bot commented Mar 2, 2024

@israel-hdez: Overrode contexts on behalf of israel-hdez: ci/prow/e2e-fast, ci/prow/e2e-slow

In response to this:

/override ci/prow/e2e-slow ci/prow/e2e-fast

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b4a042e into opendatahub-io:master Mar 2, 2024
28 checks passed
@israel-hdez israel-hdez deleted the jira-3396-wkand-master branch March 4, 2024 19:06
Jooho pushed a commit to Jooho/kserve that referenced this pull request May 7, 2024
…tudio-kserve-storage-initializer-nightly

Red Hat Konflux update kserve-storage-initializer-nightly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants