Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARRY: Set waitForPodsReady to true by default #23

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

Bobbins228
Copy link

What type of PR is this?

What this PR does / why we need it:

This is needed to differentiate the admitted and running state in the DW dashboard.

Which issue(s) this PR fixes:

Fixes RHOAIENG-4797

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Copy link

@astefanutti astefanutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some of the upstream e2e tests may need some adaptation to run with that option enabled.

@astefanutti
Copy link

/cc @jiripetrlik

@openshift-ci openshift-ci bot requested a review from jiripetrlik April 4, 2024 13:01
@ChughShilpa
Copy link

/retest

Copy link

openshift-ci bot commented Apr 5, 2024

@Bobbins228: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-kueue 4772fb5 link true /test e2e-odh-kueue

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dimakis
Copy link

dimakis commented Apr 5, 2024

/lgtm

@dimakis
Copy link

dimakis commented Apr 5, 2024

/approve

Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Bobbins228, dimakis
Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dimakis dimakis merged commit db3e81a into opendatahub-io:dev Apr 5, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants