Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CARRY: Add delete patch to remove default namespace #28

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

KPostOffice
Copy link

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Signed-off-by: Kevin <kpostlet@redhat.com>
Copy link

openshift-ci bot commented Apr 19, 2024

@KPostOffice: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-kueue a723cb0 link true /test e2e-odh-kueue

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astefanutti, KPostOffice, zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KPostOffice,astefanutti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@astefanutti astefanutti merged commit d3d458d into opendatahub-io:dev Apr 22, 2024
0 of 2 checks passed
@sutaakar
Copy link

sutaakar commented Apr 22, 2024

What about removing namespace creation instead of creating and then deleting it?
https://github.com/opendatahub-io/kueue/blob/dev/config/components/manager/manager.yaml#L1-L6

@astefanutti
Copy link

Generally we try not to touch the upstream configuration to avoid conflicts on rebase whenever possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants