Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elyra does not redirect to the correct URL after submitting a pipeline run #130

Closed
harshad16 opened this issue Jun 29, 2023 · 2 comments
Closed
Assignees
Labels
feature/elyra field-priority Prioritized by the team JIRA jira issue exists for following github issue kind/bug Something isn't working

Comments

@harshad16
Copy link
Member

harshad16 commented Jun 29, 2023

Description of problem:

After submitting a pipeline run, Elyra will show a popup with a link to the run details:
image-2023-06-12-11-32-12-307

The URL in Run Details is: https:///pipelineRuns/luca/#/runs/details/
However, when clicking this link, the Dashboard page that loads is the main Runs page of the DS Pipelines section:
image-2023-06-12-11-34-00-507

I noticed that moving between the Scheduled and Triggered pages did not change the URL of the page, and in fact the URL could be trimmed down to [https:///pipelineRuns/luca/] and we would be looking at the same page(s).
When clicking the name of one of the Triggered runs, we get sent to the actual Run details page of that run, and this is the URL that is used: https:///pipelineRuns/luca/pipelineRun/view/ (notice that the run ID from the first URL is the same here, assuming we're looking at the same run)

Prerequisites (if any, like setup, operators/versions):

RHODS 1.28 RC

Steps to Reproduce
Spawn image with Elyra
Submit pipeline run
Click on Run Details link in success popup
Actual results:

You are redirected to "main" page of DS Pipelines Runs for your project

Expected results:

You are redirected to the run details of the run you submitted

Reproducibility (Always/Intermittent/Only Once):

Always

Build Details:
Workaround:

Go to Triggered -> Last pipeline run manually

Additional info:

The fact that the URL https:///pipelineRuns/luca/#/runs/details/ does not uniquely identify a page and is equivalent to [https:///pipelineRuns/luca/] might be a bug of its own

JIRA: https://issues.redhat.com/browse/RHODS-9335

@harshad16 harshad16 added kind/bug Something isn't working JIRA jira issue exists for following github issue labels Jun 29, 2023
@harshad16
Copy link
Member Author

harshad16 commented Jul 3, 2023

Pre-requisites knowledges:

Install on the RHODS/ODH on cluster

Steps to fix the issue:

  1. Patch this path by removing the /runs/details/ from
    https://github.com/elyra-ai/elyra/blob/3c27ada25a27b719529e88268bed38d135e40805/elyra/pipeline/kfp/processor_kfp.py#L438
    https://github.com/elyra-ai/elyra/blob/3c27ada25a27b719529e88268bed38d135e40805/elyra/pipeline/kfp/processor_kfp.py#L454

  2. Include view to odh-dashboard:
    https://github.com/opendatahub-io/odh-dashboard/blob/e7f3931144fa6ed0a6b23e9678614bf502fe0d05/frontend/src/concepts/pipelines/elyra/utils.ts#L66C32-L66C32

How to test the changes:

  • Makes the change and the build images
  • Apply those PR images in an RHODS/ODH cluster
  • Running the DSP examples.
  • Check the path the prompt re-direct.

@harshad16
Copy link
Member Author

@harshad16 harshad16 added the field-priority Prioritized by the team label Jul 17, 2023
harshad16 added a commit to harshad16/odh-notebooks that referenced this issue Feb 2, 2024
sync release-2023b branch with all changes for feature-freeze rhoai 2.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/elyra field-priority Prioritized by the team JIRA jira issue exists for following github issue kind/bug Something isn't working
Projects
Status: IDE
Archived in project
Development

No branches or pull requests

2 participants