Update datascience pipeline run URL in Elyra #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
harshad16
pushed a commit
to harshad16/odh-notebooks
that referenced
this pull request
Jul 14, 2023
harshad16
pushed a commit
to harshad16/odh-notebooks
that referenced
this pull request
Jul 14, 2023
harshad16
pushed a commit
to harshad16/odh-notebooks
that referenced
this pull request
Sep 27, 2023
harshad16
added a commit
to harshad16/odh-notebooks
that referenced
this pull request
Feb 9, 2024
Mount the secret on the buildConfig instead of using ENVs to avoid their exposure on the logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:#130
Complementary PR from the odh-dashboard side: opendatahub-io/odh-dashboard#1461
Description
Extended the already-present Elyra patch used in
datascience-ubi9-python-3.9Dockerfile to change the base URL pointing to datascience pipeline runs, so that it correctly identifies particular runs.How Has This Been Tested?
Not fully tested yet, testing in progress
Merge criteria: