Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2023b] RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #569

Merged
merged 2 commits into from
Jun 17, 2024
Merged

[2023b] RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location #569

merged 2 commits into from
Jun 17, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #553

/assign jiridanek

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 17, 2024
Merged
3 tasks
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 22b6f82 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

harshad16
harshad16 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 💯

@openshift-ci openshift-ci bot added the lgtm label Jun 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit a013471 into opendatahub-io:2023b Jun 17, 2024
1 of 3 checks passed
@jstourac
Copy link
Member

Hey @harshad16 @jiridanek - didn't we miss this place? https://github.com/opendatahub-io/notebooks/blob/2023b/codeserver/c9s-python-3.9/Dockerfile#L41 🤔 or don't we care?

@jiridanek
Copy link
Member

I did grep for rpmfind in main, created or, later cherrypicked pr to 2023b. So probably this is some difference between branches? I'll be back porting the CentOS stream8 too, so I'll recheck all when doing that.

@jstourac
Copy link
Member

yes, this is the difference in the branches

jiridanek added a commit to jiridanek/notebooks that referenced this pull request Jun 18, 2024
@jiridanek
[2023b] RHOAIENG-8740 Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm downloa…
ec0e9e4 
…d location (opendatahub-io#569)

This is a manual backport for the files
missing in 2024a for the changes done in RHOAIENG-8255
@jiridanek jiridanek mentioned this pull request Jun 18, 2024
Merged
3 tasks
@jiridanek
Copy link
Member

jiridanek commented Jun 18, 2024 •
edited
Loading

Created

to address the difference

openshift-merge-bot bot added a commit that referenced this pull request Jun 18, 2024
@openshift-merge-bot
Merge pull request #570 from jiridanek/2023b
d9e264b 
[2023b] RHOAIENG-8740 Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location (#569)
jiridanek added a commit to jiridanek/notebooks that referenced this pull request Jun 18, 2024
@jiridanek
[2023b] RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm downlo…
ebc6e99 
…ad location (opendatahub-io#569)

* RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location

Previously used location is now unavailable and returns 404 error.

This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619

* fixup from review, use a little bit more proper rpm link

---------

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

also fix the rhel9 downstream-only build

(cherry picked from commit 446c6cb)

[2023b] RHOAIENG-8740 Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location (opendatahub-io#569)

This is a manual backport for the files
missing in 2024a for the changes done in RHOAIENG-8255
jiridanek added a commit to jiridanek/notebooks that referenced this pull request Jun 18, 2024
@jiridanek
[2023b] RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm downlo…
9e7165f 
…ad location (opendatahub-io#569)

* RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location

Previously used location is now unavailable and returns 404 error.

This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619

* fixup from review, use a little bit more proper rpm link

---------

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

also fix the rhel9 downstream-only build

(cherry picked from commit 446c6cb)

[2023b] RHOAIENG-8740 Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location (opendatahub-io#569)

This is a manual backport for the files
missing in 2024a for the changes done in RHOAIENG-8255
harshad16 pushed a commit to red-hat-data-services/notebooks that referenced this pull request Jun 21, 2024
@jiridanek
[2023b] RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm downlo…
01b91df 
…ad location (opendatahub-io#569) (#276)

* RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location

Previously used location is now unavailable and returns 404 error.

This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619

* fixup from review, use a little bit more proper rpm link

---------

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

also fix the rhel9 downstream-only build

(cherry picked from commit 446c6cb)

[2023b] RHOAIENG-8740 Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location (opendatahub-io#569)

This is a manual backport for the files
missing in 2024a for the changes done in RHOAIENG-8255
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/notebooks that referenced this pull request Jul 12, 2024
@jiridanek
RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download locat…
c7d9442 
…ion (opendatahub-io#569)

* RHOAIENG-8255: Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location

Previously used location is now unavailable and returns 404 error.

This new location comes from https://koji.fedoraproject.org/koji/buildinfo?buildID=2028619

* fixup from review, use a little bit more proper rpm link

---------

Co-authored-by: Jiri Daněk <jdanek@redhat.com>

also fix the rhel9 downstream-only build

(cherry picked from commit 446c6cb)

[2023b] RHOAIENG-8740 Fix spawn-fcgi-1.6.3-23.fc37.x86_64.rpm download location (opendatahub-io#569)

This is a manual backport for the files
missing in 2024a for the changes done in RHOAIENG-8255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@dibryant dibryant Awaiting requested review from dibryant

Assignees

@jiridanek jiridanek

@harshad16 harshad16

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @jstourac @jiridanek @harshad16