This repository has been archived by the owner on Mar 17, 2023. It is now read-only.
Rebase to master #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added documentation and tests
fix dangling f-string Co-authored-by: Erik Sundell <erik.i.sundell@gmail.com>
This is copied from jupyterhub/jupyterhub's test suite made by MinRK!
[OpenShift] add allowed_groups and admin_groups
…rhub1.2 Test oldest dependencies and bump jupyterhub required to 1.2
added allowed_groups and admin_groups to generic.py
consolidates: - httpclient instantiation - error logging - json deserialization reduces duplicate code across implementations
Add `.fetch(req)` method to base OAuthenticator
Clear cookie on logout
…oogle Support username_claim in Google OAuth
…a_method-config [Generic] Remove userdata_method configuration supposedly not relevant
…ional-whitelist [Google] Allow for checking of google_groups for admin only
…erdata_method docs: cleanup userdata_method from docs
ensures we cover use of pyjwt
[azuread] pyjwt 1+2 compatibility, azuread test coverage
As commented in jupyterhub#366 (review) it should be noted that whitelist for groups and projects works in gitlab if still on version 1.2. I spend some hours because I did not realise the doc refers to a version which is not the standard version.
Changelog for 14.0
Note that whitelist should be used if not in 1.2
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
Remove unused imports, reduce flake8 exclusions list
pre-commit configured and executed
vpavlin
force-pushed
the
feature/rebase
branch
2 times, most recently
from
a1a561b
to
dd1d2ae
Compare
In some clusters, the OpenShift oauth endpoint will not be self-signed like the api endpoint. In this case, retry calls to the oauth endpoint with the default system ca bundle.
|
Any recommendation for reviewers on this one? it lgtm, but I'm not an expert on this codebase. |
|
Well, mainly just check if you are able to login to ODH with this and if all the group stuff works |
crobby
approved these changes
Jun 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.