Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for when topology has visual runAfters in use #1234

Conversation

andrewballantyne
Copy link
Member

@andrewballantyne andrewballantyne commented May 16, 2023

Closes: #1233

Description

Uses the runAfter state if any of the nodes have it -- to prevent mixing and matching and potentially causing duplicate lines.

From:
image

To:
image

How Has This Been Tested?

Using a Pipeline that has runAfter usage to view the Pipeline. Let me know if you need to see my example, it's taken from another source and I'm not sure how public that is.

Test Impact

None -- no tests.

Request review criteria:

  • The commits have meaningful messages (squashes happen on merge by the bot).
  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lucferbux
Copy link
Contributor

@andrewballantyne I've tried to set up a pipeline like this to test it, and I couldn't manage it, I've reviewed the code but didn't fully test the functionality, can you share me an example on how to deploy this kind of pipelines?

Copy link
Member

@Gkrumbach07 Gkrumbach07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

got it working in the UI and it works as expected

@Gkrumbach07
Copy link
Member

This is a smallish feature/bug fix with 2 LGTM tags.

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Gkrumbach07, lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lucferbux
Copy link
Contributor

[Updated] I've managed to test it, works fine. cc @andrewballantyne

Screenshot 2023-05-18 at 15 50 59

@openshift-merge-robot openshift-merge-robot merged commit 501ac7b into opendatahub-io:main May 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pipeline Rendering Issue on runAfter Usage
4 participants