Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for when topology has visual runAfters in use #1234

Merged
merged 1 commit into from
May 18, 2023
Merged

Fix for when topology has visual runAfters in use #1234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 17 additions & 8 deletions frontend/src/concepts/pipelines/topology/usePipelineTaskTopology.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,26 @@ export const usePipelineTaskTopology = (
return EMPTY_STATE;
}

const hasRunAfters = tasks.some((t) => !!t.runAfter);

const edgeLookupMap = tasks.reduce<Record<string, Set<string>>>((acc, task) => {
const { name, params, when } = task;
const { name, params, when, runAfter } = task;

const targets: string[] = [];
if (params) {
const paramNames = params.map(paramAsRunAfter).filter(isTruthyString);
targets.push(...paramNames);
}
if (when) {
const paramNames = when.map(whenAsRunAfter).filter(isTruthyString);
targets.push(...paramNames);
if (hasRunAfters) {
// Run afters are to be respected, there or not, ignore dependencies
// They choose to use runAfters or not, don't mix and match it will cause weird graphs
targets.push(...(runAfter ?? []));
} else {
// Don't have runAfters, we'll have to figure out what the lines might be based on dependencies
if (params) {
const paramNames = params.map(paramAsRunAfter).filter(isTruthyString);
targets.push(...paramNames);
}
if (when) {
const paramNames = when.map(whenAsRunAfter).filter(isTruthyString);
targets.push(...paramNames);
}
}

return targets.reduce((acc, target) => {
Expand Down