-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display error message on enabling TrustyAI via UI #2036
Display error message on enabling TrustyAI via UI #2036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
this works fine
@alexcreasy this might be benefited from us making use of my #2032 PR to just straight up hide the checkbox. We'll need to probably pivot to that over time, this may be okay for now if you approve of it. |
@andrewballantyne thanks for the comment, if I'd read it earlier it would have bypassed a whole slack conversation lol. I'm still going to approve this PR (pending changes) as it fixes a flaw in the current implementation and at least makes this usable for now. I'd like to look at utilising your PR as a priority afterwards when possible. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4cad1d9
into
opendatahub-io:f/mserving-metrics
@andrewballantyne This feature is not available in 2.5.We have Components and Permissions tab on data science project page,No Settings tab. |
@sthundat This is not in 2.5, you won't see it there. |
Closes: #1996
Description
This PR aims to display error message on enabling TrustyAI via UI.
How Has This Been Tested?
Test Impact
NA
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main