Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display error message on enabling TrustyAI via UI #2036

Merged

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Oct 31, 2023

Closes: #1996

Description

This PR aims to display error message on enabling TrustyAI via UI.

Screenshot from 2023-10-31 19-21-23

How Has This Been Tested?

  1. Create a Data Science Project
  2. Navigate to DSP page
  3. Click Settings
  4. Check the Enable TrustyAI checkbox, you will show the error (only if TrustyAIService CRD not installed on your cluster)

Test Impact

NA

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@alexcreasy alexcreasy requested review from pnaik1 and removed request for alexcreasy, lucferbux and DaoDaoNoCode October 31, 2023 15:03
Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

this works fine

@manaswinidas manaswinidas self-assigned this Oct 31, 2023
@pnaik1
Copy link
Contributor

pnaik1 commented Oct 31, 2023

Works fine
/lgtm
Screenshot from 2023-11-01 01-29-33

@andrewballantyne
Copy link
Member

@alexcreasy this might be benefited from us making use of my #2032 PR to just straight up hide the checkbox.

We'll need to probably pivot to that over time, this may be okay for now if you approve of it.

@openshift-ci openshift-ci bot removed the lgtm label Nov 1, 2023
@alexcreasy
Copy link
Contributor

@alexcreasy this might be benefited from us making use of my #2032 PR to just straight up hide the checkbox.

We'll need to probably pivot to that over time, this may be okay for now if you approve of it.

@andrewballantyne thanks for the comment, if I'd read it earlier it would have bypassed a whole slack conversation lol. I'm still going to approve this PR (pending changes) as it fixes a flaw in the current implementation and at least makes this usable for now. I'd like to look at utilising your PR as a priority afterwards when possible.

@alexcreasy
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexcreasy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4cad1d9 into opendatahub-io:f/mserving-metrics Nov 7, 2023
4 checks passed
@sthundat
Copy link
Contributor

sthundat commented Dec 6, 2023

@andrewballantyne This feature is not available in 2.5.We have Components and Permissions tab on data science project page,No Settings tab.

@andrewballantyne
Copy link
Member

@sthundat This is not in 2.5, you won't see it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Error message on enabling TrustyAI via UI are not descriptive
6 participants