Add region field when configuring pipeline server #2592
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/RHOAIENG-2283
Description
Add the region field and set it as required when configuring a pipeline server, the default value is
us-east-1
Also, when the endpoint is
s3.amazonaws.com
, we convert thehost
field in DSPA to add the region information in.How Has This Been Tested?
spec.objectStorage.externalStorage.host
is converted. If the endpoint iss3.amazonaws.com
, it should be converted. Otherwise, we keep it unchanged.Test Impact
Add unit tests to verify the converted host is correct.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main