Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region field when configuring pipeline server #2592

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Mar 11, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-2283

Description

Add the region field and set it as required when configuring a pipeline server, the default value is us-east-1

Screenshot 2024-03-11 at 5 56 29 PM

Also, when the endpoint is s3.amazonaws.com, we convert the host field in DSPA to add the region information in.

How Has This Been Tested?

  1. Create a project
  2. Configure a pipeline server
  3. Make sure the region field is pre-filled and is required
  4. When you submit the creation, go to DSPA to check whether the spec.objectStorage.externalStorage.host is converted. If the endpoint is s3.amazonaws.com, it should be converted. Otherwise, we keep it unchanged.

Test Impact

Add unit tests to verify the converted host is correct.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@Gkrumbach07
Copy link
Member

tested and works. tests look good. no UI changes needing UX. We dont validate the validity of region right now, but then again we dont validate a lot of fields besides host so i think we are fine until people start adding extra spaces to their regions too. No errors runtime errors if you throw random values into the region too.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a9d30c5 into opendatahub-io:main Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants