Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added test cases for data connection #2593

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

pnaik1
Copy link
Contributor

@pnaik1 pnaik1 commented Mar 12, 2024

Closes: https://issues.redhat.com/browse/RHOAIENG-3810

Description

Added cypress test for data connection in project

How Has This Been Tested?

npm run test

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests may change according to #2592 since this is going in earlier.

@pnaik1 pnaik1 force-pushed the data-connections branch 3 times, most recently from c9ec266 to cc6f99a Compare March 13, 2024 10:36
@pnaik1
Copy link
Contributor Author

pnaik1 commented Mar 13, 2024

The tests may change according to #2592 since this is going in earlier.

The PR didn't affect the cypress test

@manaswinidas
Copy link
Contributor

The PR didn't affect the cypress test

Oh yes, that PR was for pipeline server, not data connection... 🤕 my bad

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppadti
Copy link
Contributor

ppadti commented Mar 15, 2024

/lgtm

@christianvogt
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit da0c650 into opendatahub-io:main Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants