Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup BYON references in the UI #426

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Cleanup BYON references in the UI #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/pages/BYONImages/BYONImages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ const BYONImages: React.FC = () => {

return (
<ApplicationsPage
title="BYON image settings"
title="Notebook image settings"
description={description}
loaded={loaded}
empty={isEmpty}
loadError={loadError}
errorMessage="Unable to load BYON images."
errorMessage="Unable to load notebook images."
emptyStatePage={noImagesPageSection}
>
{!isEmpty ? (
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/BYONImages/BYONImagesTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ export const BYONImagesTable: React.FC<BYONImagesTableProps> = ({ images, forceU
</Toolbar>
<TableComposable
className={tableFilter.count === 0 ? 'empty-table' : ''}
aria-label="BYON Images table"
aria-label="Notebook images table"
variant="compact"
>
<Thead>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/BYONImages/DeleteBYONImageModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export const DeleteImageModal: React.FC<ImportImageModalProps> = ({
return (
<Modal
variant={ModalVariant.medium}
title="Delete Notebook image"
title="Delete notebook image"
titleIconVariant="warning"
isOpen={isOpen}
onClose={onCloseHandler}
Expand Down
18 changes: 9 additions & 9 deletions frontend/src/pages/BYONImages/ImportImageModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export const ImportImageModal: React.FC<ImportImageModalProps> = ({
return (
<Modal
variant={ModalVariant.medium}
title="Import BYON images"
title="Import notebook images"
isOpen={isOpen}
onClose={onCloseHandler}
actions={[
Expand All @@ -84,7 +84,7 @@ export const ImportImageModal: React.FC<ImportImageModalProps> = ({
addNotification({
status: 'danger',
title: 'Error',
message: `Unable to add BYON image ${name}`,
message: `Unable to add notebook image ${name}`,
timestamp: new Date(),
}),
);
Expand Down Expand Up @@ -114,7 +114,7 @@ export const ImportImageModal: React.FC<ImportImageModalProps> = ({
label="Repository"
isRequired
fieldId="byon-image-repository-label"
helperText="Repo where byon images are stored."
helperText="Repo where notebook images are stored."
helperTextInvalid="This field is required."
helperTextInvalidIcon={<ExclamationCircleIcon />}
validated={validRepo ? undefined : 'error'}
Expand Down Expand Up @@ -226,8 +226,8 @@ export const ImportImageModal: React.FC<ImportImageModalProps> = ({
No software added
</Title>
<EmptyStateBody>
Add software to be advertised with your BYON image. Making changes here won’t
affect the contents of the image.{' '}
Add software to be advertised with your notebook image. Making changes here
won’t affect the contents of the image.{' '}
</EmptyStateBody>
<Button
className="empty-button"
Expand All @@ -253,8 +253,8 @@ export const ImportImageModal: React.FC<ImportImageModalProps> = ({
<>
<TableComposable aria-label="Simple table" variant="compact" isStickyHeader>
<Caption>
Add the advertised packages shown with this BYON image. Modifying the packages
here does not effect the contents of the BYON image.
Add the advertised packages shown with this notebook image. Modifying the
packages here does not effect the contents of the notebook image.
</Caption>
<Thead>
<Tr>
Expand Down Expand Up @@ -304,8 +304,8 @@ export const ImportImageModal: React.FC<ImportImageModalProps> = ({
No packages added
</Title>
<EmptyStateBody>
Add packages to be advertised with your BYON image. Making changes here won’t
affect the contents of the image.{' '}
Add packages to be advertised with your notebook image. Making changes here
won’t affect the contents of the image.{' '}
</EmptyStateBody>
<Button
className="empty-button"
Expand Down
16 changes: 8 additions & 8 deletions frontend/src/pages/BYONImages/UpdateImageModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ export const UpdateImageModal: React.FC<UpdateImageModalProps> = ({
<>
<TableComposable aria-label="Simple table" variant="compact">
<Caption>
Change the advertised software shown with this BYON image. Modifying the
software here does not effect the contents of the BYON image.
Change the advertised software shown with this notebook image. Modifying the
software here does not effect the contents of the notebook image.
</Caption>
<Thead>
<Tr>
Expand Down Expand Up @@ -207,8 +207,8 @@ export const UpdateImageModal: React.FC<UpdateImageModalProps> = ({
No software added
</Title>
<EmptyStateBody>
Add software to be advertised with your BYON image. Making changes here won’t
affect the contents of the image.{' '}
Add software to be advertised with your notebook image. Making changes here
won’t affect the contents of the image.{' '}
</EmptyStateBody>
<Button
id="add-software-button"
Expand All @@ -235,8 +235,8 @@ export const UpdateImageModal: React.FC<UpdateImageModalProps> = ({
<>
<TableComposable aria-label="Simple table" variant="compact" isStickyHeader>
<Caption>
Change the advertised packages shown with this BYON image. Modifying the
packages here does not effect the contents of the BYON image.
Change the advertised packages shown with this notebook image. Modifying the
packages here does not effect the contents of the notebook image.
</Caption>
<Thead>
<Tr>
Expand Down Expand Up @@ -287,8 +287,8 @@ export const UpdateImageModal: React.FC<UpdateImageModalProps> = ({
No packages added
</Title>
<EmptyStateBody>
Add packages to be advertised with your BYON image. Making changes here won’t
affect the contents of the image.{' '}
Add packages to be advertised with your notebook image. Making changes here
won’t affect the contents of the image.{' '}
</EmptyStateBody>
<Button
id="add-package-button"
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/pages/notebookController/screens/server/SpawnerPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ const SpawnerPage: React.FC = React.memo(() => {
<>
{impersonatingUser && <ImpersonateAlert />}
<ApplicationsPage
title="Start a Notebook server"
description="Select options for your Notebook server."
title="Start a notebook server"
description="Select options for your notebook server."
loaded={loaded}
loadError={loadError}
empty={!images || images.length === 0}
Expand Down Expand Up @@ -368,7 +368,7 @@ const SpawnerPage: React.FC = React.memo(() => {
<Alert
variant="danger"
isInline
title="Failed to create the Notebook, please try again later"
title="Failed to create the notebook, please try again later"
>
{submitError.message}
</Alert>
Expand Down