feat(data-catalog): Adding Thriftserver #228
Conversation
|
Hi @tumido. Thanks for your PR. I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tumido
changed the title
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
89e8110
to
8565bf9
Compare
|
/retest failure unrelated to PR |
|
/retest test failures not related to the code change |
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
dcb4596
to
422084b
Compare
|
/retest |
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
422084b
to
f4dfa35
Compare
|
/retest |
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
83844e0
to
80fa2b7
Compare
tumido
force-pushed
the
datacatalog-thriftserver
branch
2 times, most recently
from
e8effd9
to
c76777e
Compare
thriftserver/thriftserver/overlays/create-spark-cluster/spark-cluster.yaml
Show resolved
Hide resolved
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
11d37e6
to
20be83d
Compare
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
20be83d
to
3d2bba5
Compare
|
Rebased to master. Tests are flaky again. I'll retest it later. |
|
/retest |
tumido
force-pushed
the
datacatalog-thriftserver
branch
2 times, most recently
from
94c93fc
to
7d94878
Compare
| - create-spark-cluster | ||
| parameters: | ||
| - name: s3_endpoint_url | ||
| value: s3.odh.com |
There was a problem hiding this comment.
is the protocol required here if we need to use unsecured http?
There was a problem hiding this comment.
I don't think so you need to do that. As you can see here, we use it like this in operate first and it works just fine:
|
The tests for this actually failed: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/opendatahub-io_odh-manifests/228/pull-ci-opendatahub-io-odh-manifests-master-odh-manifests-e2e/1337056179376885760/artifacts/odh-manifests-e2e/e2e/container-logs/test.log Not sure why it was reported as a success. I'll take a look at the test wrapper. |
Ok, I have spotted the issue with the tests and have a PR up to fix that problem: #267 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaVLaS, tumido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
7d94878
to
c842c03
Compare
|
Rebased 👍 |
tumido
force-pushed
the
datacatalog-thriftserver
branch
from
c842c03
to
3916265
Compare
|
/lgtm |
|
@maulikjs: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
Adding Thriftserver component Data catalog.
Part of: https://github.com/opendatahub-io/odh-manifests/issues/222, https://github.com/opendatahub-io/odh-manifests/issues/105, DATAHUB-2294
Based on reference implementation in AICoE#29 for Internal DH.
It will need further cleanup and extraction of parts into overlays later on (storage class, externalize the database). This is expected to happen in consecutive PRs.