Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: segment-io CM namespace from monitoring to application's #433

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Aug 11, 2023

Description

From testing :

Changing this setting from the dashboard "cluster settings" page appears to work fine, but in the backend I see no changes to the odh-segment-key configmap.
configmap/secret from segment is now stored in the monitoring namespace instead of the applications namespace.

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link
Contributor

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etirelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2fd4bea into opendatahub-io:feature-rearchitecture Aug 11, 2023
5 checks passed
@zdtsw
Copy link
Member Author

zdtsw commented Aug 14, 2023

ref: #445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants