Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update segment-io namespace to use application's not monitoring's #34

Merged

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Aug 11, 2023

From testing :

 Changing this setting from the dashboard "cluster settings" page appears to work fine, but in the backend I see no changes to the odh-segment-key configmap.
configmap/secret from segment is now stored in the monitoring namespace instead of the applications namespace.

This PR is to change namespace where segment-io CM is created.
cherry-pick : opendatahub-io#433

fix: opendatahub-io#445

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Copy link

@etirelli etirelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@VaishnaviHire VaishnaviHire merged commit 3f828d6 into red-hat-data-services:rhods-1.31 Aug 15, 2023
2 checks passed
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Aug 31, 2023
- reapply PR red-hat-data-services#34

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw mentioned this pull request Aug 31, 2023
zdtsw added a commit to zdtsw-forking/rhods-operator that referenced this pull request Aug 31, 2023
- reapply PR red-hat-data-services#34

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants