Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(kserve): manifests path from in-repo #657

Merged
merged 2 commits into from
Oct 30, 2023
Merged

update(kserve): manifests path from in-repo #657

merged 2 commits into from
Oct 30, 2023

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Oct 21, 2023 •
edited

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci
Copy link

openshift-ci bot commented Oct 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lavlas for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zdtsw zdtsw added the odh-1.11 label Oct 21, 2023
@israel-hdez israel-hdez mentioned this pull request Oct 24, 2023
Merged
1 task
@zdtsw
Copy link
Member Author

zdtsw commented Oct 25, 2023

/test opendatahub-operator-e2e

@zdtsw zdtsw requested review from VaishnaviHire and removed request for LaVLaS October 25, 2023 04:49
@zdtsw zdtsw mentioned this pull request Oct 30, 2023
Closed
3 tasks
@zdtsw
update: no more odh-manifests in ODH build
ec3bd4c 
- remove modelmesh-monitoring which only for downstream monitoring
- add kserve

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw
Copy link
Member Author

zdtsw commented Oct 30, 2023

/test opendatahub-operator-e2e

@zdtsw zdtsw enabled auto-merge (squash) October 30, 2023 19:00
@zdtsw zdtsw merged commit 890da22 into opendatahub-io:incubation Oct 30, 2023
6 of 7 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Nov 15, 2023
@zdtsw @VaishnaviHire
update(kserve): manifests path from in-repo (opendatahub-io#657)
e59cf04 
* update(kserve): manifests path from in-repo
* update: no more odh-manifests in ODH build

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 890da22)
@VaishnaviHire VaishnaviHire mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etirelli etirelli Awaiting requested review from etirelli

@VaishnaviHire VaishnaviHire Awaiting requested review from VaishnaviHire

Assignees
No one assigned
Labels
odh-1.11
Projects
ODH Platform Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@zdtsw