-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for odh-opeartor v2 #107
Preparation for odh-opeartor v2 #107
Conversation
@israel-hdez could you update the description of how to test this pr and what reviewers need to check? |
@Jooho I just provided testing instructions. |
v2 failed :
|
Open Data Hub operator v2 is going to be consuming Kustomize manifests from component repos, and `odh-manifests` repo is going to be archived. This is moving/copying artifacts from `odh-manifests` into an already existent odh overlay. With these changes, the overlay can be directly consumed by ODH-operator v2. Additionally, this should fix a build issue in the storage-initializer. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
4d8274d
to
f5484b1
Compare
I tested this pr and this is summary:
Test result:
As we discussed, regarding 3 dot above, you will do the following
Please keep tracking this until it is done. when they create a ticket(pr), please attach the link here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: israel-hdez, VedantMahabaleshwarkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@israel-hdez confirmed
|
* add caikit-only dockerfile - create caikit image using UBI as base - use poetry to lock deps instead of pipenv * docs: update caikit-tgis example * remove smoketest * cleanup kserve docs * update image names/tags
…tudio-kserve-qptext Red Hat Konflux update kserve-qptext
What this PR does / why we need it:
Open Data Hub operator v2 is going to be consuming Kustomize manifests from component repos, and
odh-manifests
repo is going to be archived.This is moving/copying artifacts from
odh-manifests
into an already existent odh overlay. With these changes, the overlay can be directly consumed by ODH-operator v2.Additionally, this should fix a build issue in the storage-initializer.
Related #72
Type of changes
Testing
You can test in two ways:
Testing with kustomize
Simply, build with kustomize:
It should render the manifests without error.
Testing with odh-operator v2
Use the following YAML in the DSC:
The operator should deploy and KServe should be ready to deploy models.