Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for odh-opeartor v2 #107

Merged

Conversation

israel-hdez
Copy link

@israel-hdez israel-hdez commented Oct 13, 2023

What this PR does / why we need it:

Open Data Hub operator v2 is going to be consuming Kustomize manifests from component repos, and odh-manifests repo is going to be archived.

This is moving/copying artifacts from odh-manifests into an already existent odh overlay. With these changes, the overlay can be directly consumed by ODH-operator v2.

Additionally, this should fix a build issue in the storage-initializer.

Related #72

Type of changes

  • New feature (non-breaking change which adds functionality)

Testing

You can test in two ways:

Testing with kustomize

Simply, build with kustomize:

kustomize build config/overlays/odh

It should render the manifests without error.

Testing with odh-operator v2

Use the following YAML in the DSC:

spec:
  components:
    kserve:
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: 'https://github.com/israel-hdez/kserve/tarball/manifest-opv2-0110'
      managementState: Managed

The operator should deploy and KServe should be ready to deploy models.

@israel-hdez israel-hdez linked an issue Oct 13, 2023 that may be closed by this pull request
@Jooho
Copy link

Jooho commented Oct 13, 2023

@israel-hdez could you update the description of how to test this pr and what reviewers need to check?

@israel-hdez
Copy link
Author

@Jooho I just provided testing instructions.

@Jooho
Copy link

Jooho commented Oct 16, 2023

v2 failed :

      waiting:
        message: Back-off pulling image "quay.io/opendatahub/kserve-controller:v0.11.0.1"

Open Data Hub operator v2 is going to be consuming Kustomize manifests
from component repos, and `odh-manifests` repo is going to be archived.

This is moving/copying artifacts from `odh-manifests` into an already
existent odh overlay. With these changes, the overlay can be directly
consumed by ODH-operator v2.

Additionally, this should fix a build issue in the storage-initializer.

Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com>
@Jooho
Copy link

Jooho commented Oct 17, 2023

I tested this pr and this is summary:

@Edgar

  1. It deployed odh-model-controller but I don't know how you deploy odh-model-controller(image: quay.io/opendatahub/odh-model-controller:stable) with transitioned manifests. It is under vendant pr(manifest readiness update for odh-operator v2 odh-model-controller#92) so it should be something we need to work on.
    Moreover, you need to update the default value for manifest like
    @Vedant Mahabaleshwarkar
    did : add manifests for odh-model-controller and model-mesh opendatahub-operator#639

Test result:

  1. I can deploy kserve operator
  2. odh-model-controller should be updated (it will be done by this PR)
  3. you need to update default manifests path in the operator
  4. I can deploy a sample operator and it works

As we discussed, regarding 3 dot above, you will do the following

About the operator, I was planning to simply tell the operator team to point to the repo, like suggested in the ADR

Please keep tracking this until it is done. when they create a ticket(pr), please attach the link here

@heyselbi heyselbi linked an issue Oct 18, 2023 that may be closed by this pull request
Copy link

@VedantMahabaleshwarkar VedantMahabaleshwarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, VedantMahabaleshwarkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [VedantMahabaleshwarkar,israel-hdez]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jooho Jooho merged commit b7c6062 into opendatahub-io:release-v0.11.0 Oct 19, 2023
18 of 20 checks passed
@Jooho
Copy link

Jooho commented Oct 19, 2023

@israel-hdez confirmed

  • that the failed gitaction is because we patched some security issues for snyk.
  • this issue will be fixed with upstream update

@israel-hdez
Copy link
Author

Jooho pushed a commit to Jooho/kserve that referenced this pull request Jan 11, 2024
* add caikit-only dockerfile

- create caikit image using UBI as base
- use poetry to lock deps instead of pipenv

* docs: update caikit-tgis example

* remove smoketest

* cleanup kserve docs

* update image names/tags
Jooho pushed a commit to Jooho/kserve that referenced this pull request Feb 28, 2024
…tudio-kserve-qptext

Red Hat Konflux update kserve-qptext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move from odh-manifests to Kserve source repo
3 participants