Follow-up question to select one seems broken

[florianm]

I'm having a few troubles with the current "select one":

• Select one inside groups are showing up as "invalid" no matter what I do with the follow up question. I see the inline error message "Because this control is within a single-screen group (field list), any expressions that reference other fields in the same group will not work."
• The "Ask if the response is" dropdown is inactive when "Follow up question" is checked - shouldn't it be the other way around? This means I can't choose which option to follow up on.

A MWE: choice_one shows up as invalid in ODK Build, choice_two works.
Uploaded to an ODK Aggregate server and filled in in ODK Collect, the behaviour is:

• choice_one is followed up by text_following_choice_one, both live in a group.
• I can only follow up choice_one's option one (as ODK-B dropdown for follow up is inactive and won't let me change option to follow up on).
• When selecting choice_one's option one (with follow up) I won't see the follow up field until I swipe forward and back again.
• choice_two works fine, except that I can't choose which option to follow up on.

It would be awesome if the follow-up could be ignored inside groups (maybe the "invalid" status is a false positive?), and if the follow-up dropdown could be active when follow up is selected (bug?).

<h:html xmlns="http://www.w3.org/2002/xforms" xmlns:h="http://www.w3.org/1999/xhtml" xmlns:ev="http://www.w3.org/2001/xml-events" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:jr="http://openrosa.org/javarosa">
  <h:head>
    <h:title>follow up bugs 0.1</h:title>
    <model>
      <instance>
        <data id="build_follow-up-bugs-0-1_1498200302">
          <meta>
            <instanceID/>
          </meta>
          <a_group>
            <choice_one/>
            <text_following_choice_one/>
          </a_group>
          <choice_two/>
          <a_text_field/>
        </data>
      </instance>
      <itext>
        <translation lang="English">
          <text id="/data/a_group:label">
            <value>A group</value>
          </text>
          <text id="/data/a_group/choice_one:label">
            <value>Invalid choice field</value>
          </text>
          <text id="/data/a_group/choice_one:hint">
            <value>this shows up as invalid</value>
          </text>
          <text id="/data/a_group/choice_one:option0">
            <value>choice one</value>
          </text>
          <text id="/data/a_group/choice_one:option1">
            <value>choice two</value>
          </text>
          <text id="/data/a_group/text_following_choice_one:label">
            <value>Some text</value>
          </text>
          <text id="/data/choice_two:label">
            <value>Working choice field</value>
          </text>
          <text id="/data/choice_two:hint">
            <value>this one will work</value>
          </text>
          <text id="/data/choice_two:option0">
            <value>choice one</value>
          </text>
          <text id="/data/choice_two:option1">
            <value>choice two</value>
          </text>
          <text id="/data/a_text_field:label">
            <value>A text field</value>
          </text>
          <text id="/data/a_text_field:hint">
            <value>cannot select on which option to follow up on</value>
          </text>
        </translation>
      </itext>
      <bind nodeset="/data/meta/instanceID" type="string" readonly="true()" calculate="concat('uuid:', uuid())"/>
      <bind nodeset="/data/a_group/choice_one" type="select1"/>
      <bind nodeset="/data/a_group/text_following_choice_one" type="string" relevant="(selected(/data/a_group/choice_one, 'one'))"/>
      <bind nodeset="/data/choice_two" type="select1"/>
      <bind nodeset="/data/a_text_field" type="string" relevant="(selected(/data/choice_two, 'one'))"/>
    </model>
  </h:head>
  <h:body>
    <group appearance="field-list">
      <label ref="jr:itext('/data/a_group:label')"/>
      <select1 ref="/data/a_group/choice_one" appearance="horizontal">
        <label ref="jr:itext('/data/a_group/choice_one:label')"/>
        <hint ref="jr:itext('/data/a_group/choice_one:hint')"/>
        <item>
          <label ref="jr:itext('/data/a_group/choice_one:option0')"/>
          <value>one</value>
        </item>
        <item>
          <label ref="jr:itext('/data/a_group/choice_one:option1')"/>
          <value>two</value>
        </item>
      </select1>
      <input ref="/data/a_group/text_following_choice_one">
        <label ref="jr:itext('/data/a_group/text_following_choice_one:label')"/>
      </input>
    </group>
    <select1 ref="/data/choice_two" appearance="horizontal">
      <label ref="jr:itext('/data/choice_two:label')"/>
      <hint ref="jr:itext('/data/choice_two:hint')"/>
      <item>
        <label ref="jr:itext('/data/choice_two:option0')"/>
        <value>one</value>
      </item>
      <item>
        <label ref="jr:itext('/data/choice_two:option1')"/>
        <value>two</value>
      </item>
    </select1>
    <input ref="/data/a_text_field">
      <label ref="jr:itext('/data/a_text_field:label')"/>
      <hint ref="jr:itext('/data/a_text_field:hint')"/>
    </input>
  </h:body>
</h:html>

[issa-tseng]

Hey Florian; always good to hear from you.

You're right, something is goofy about the enable/disable state of the select box. I'm working on it.

To resolve that warning, you'll have to disable "Display on one screen" on the enclosing group. It's a limitation of Collect; it can't (doesn't bother to) reprocess the relevance logic while the whole group is already displayed.

[colinmccann]

Can we re-open this? I believe the issue of 'select question shown as invalid in group' issue is still not addressed.

From OP: Select one inside groups are showing up as "invalid" no matter what I do with the follow up question. I see the inline error message "Because this control is within a single-screen group (field list), any expressions that reference other fields in the same group will not work."

(props on all of the new changes btw - lots of great features added recently!)

[issa-tseng]

hey colin: that's unfortunate. does it happen with all your forms? and—obvious question, i'm sorry, but are you sure none of the parent groups are marked as "Display On One Screen"?

[colinmccann]

Thanks Issa. Re: Obvious question - yeah, the parent groups are marked as 'display on one screen' (sorry, I should've been explicit about this). So perhaps this is more of an issue of 'how should it work'? I feel like a display-on-one-screen-group of [select one + text] should not default to generating a warning/error - there's nothing linking those two questions per se (eg the text is not a follow up to the select). My use case is such - I have a select one with a bunch of options, the last of which is 'Other' Then I have a text box with something like 'If Other selected, please specify' I would prefer the 'If Other, please specify' text to *not* appear on a different screen (since sometimes the Select provides contextual clues for remembering how to fill in the Specify). I have been using this pattern since the dawn of ODK, so perhaps I'm stuck in my way of thinking?

…

On Wed, Jan 9, 2019 at 8:09 AM Issa Tseng ***@***.***> wrote: hey colin: that's unfortunate. does it happen with all your forms? and—obvious question, i'm sorry, but are you sure *none* of the parent groups are marked as "Display On One Screen"? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#166 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuEmKr_aK_2OOAYVLAgriEl6epLAxJjks5vBTNWgaJpZM4ODMwY> .

-- Colin McCann

[issa-tseng]

unfortunately, the restriction is due to how XForms/JavaRosa/ODK Collect work.

the follow-up question functionality shows an additional text question only when some particular select option is chosen.

but Collect only decides whether or not to display a field at the time the field is presented. when "display on one screen" is selected, all fields are presented at once, and then the display logic is never reconsidered unless the entire group is navigated away from and then back to.

this means the follow-up question won't display when you'd expect, which is why we prevent the combination.

if your intention is to always display a text field that has a label teaching the user when to/when not to fill it out, then i would suggest just adding a plain text question after the select question rather than using the follow-up question feature.

[colinmccann]

Ok, makes sense. However, I may have not been sufficiently clear. To you point: "if your intention is to *always* display a text field that has a label teaching the user when to/when not to fill it out, then i would suggest just adding a plain text question after the select question rather than using the follow-up question feature." That is indeed what I am doing. The two questions aren't linked. That is, I haven't checked the 'follow-up question' box. See below (hopefully inline photos work here): [image: Screen Shot 2019-01-09 at 8.50.28 AM.png]

…

On Wed, Jan 9, 2019 at 8:37 AM Clint Tseng ***@***.***> wrote: unfortunately, the restriction is due to how XForms/JavaRosa/ODK Collect work. the follow-up question functionality shows an additional text question *only* when some particular select option is chosen. but Collect only decides whether or not to display a field at the time the field is presented. when "display on one screen" is selected, all fields are presented at once, and then the display logic is never reconsidered unless the entire group is navigated away from and then back to. this means the follow-up question won't display when you'd expect, which is why we prevent the combination. if your intention is to *always* display a text field that has a label teaching the user when to/when not to fill it out, then i would suggest just adding a plain text question after the select question rather than using the follow-up question feature. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#166 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAuEmLo9o6koLVyMFaDC2lgcP4Hxy0l-ks5vBTmzgaJpZM4ODMwY> .

-- Colin McCann

[issa-tseng]

photo didn't work. :)

[colinmccann]

Heh, dang - trying again on GH

[issa-tseng]

ah, that's definitely a bit goofier.

[issa-tseng]

apparently long ago when i implemented validations i got partially done with implementing a warning-level severity but never fully surfaced it. the intention with this validation check was to surface a warning, not an error. so the issue is not that the error should not appear, but rather that it should not be so scary.

[issa-tseng]

fixed in #217.