Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between Geopoint widgets' button name #1859

Closed
grzesiek2010 opened this issue Feb 13, 2018 · 14 comments · Fixed by #1986
Closed

Inconsistency between Geopoint widgets' button name #1859

grzesiek2010 opened this issue Feb 13, 2018 · 14 comments · Fixed by #1986
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)

Comments

@grzesiek2010
Copy link
Member

Software and hardware versions

Collect v1.12.2 and older version

Problem description

The button text changes if any location is recorded if we use the GeopointWidget with map appearance but it doesn't if we use that widget without any appearance

screenshot_2018-02-13-13-58-13
screenshot_2018-02-13-13-58-15

Steps to reproduce the problem

You can use All Widgets form.

Expected behavior

I think the text in the first case should be changed too. Maybe View or Change Location is not good since we can't view that location but we can use eg. just Change Location

Other information

The problem is visible if we use both Google and OSM SDK.

@opendatakit-bot label "quick win"

@getodk-bot getodk-bot added the good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) label Feb 13, 2018
@Shreya001
Copy link

@grzesiek2010 can I work on this issue?

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @sammy1997! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

@sammy1997
Copy link

@opendatakit-bot claim

@sammy1997
Copy link

@Shreya001 you can claim an issue using the bot. So you don't need to tag mentors I guess. :)

@Shreya001
Copy link

Shreya001 commented Feb 13, 2018

Ok Thanks @sammy1997 :)

@grzesiek2010
Copy link
Member Author

grzesiek2010 commented Feb 14, 2018

@Shreya001 @sammy1997 that's right you can claim an issue if it's free.

@sammy1997 as I understand you added that comment only to show how it works so, please unclime now and let @Shreya001 do that.

[EDIT} I saw @Shreya001 has already claimed another issue so I think it's ok if you @sammy1997 are going to keep this one.

@sammy1997
Copy link

Ok @grzesiek2010 .

@Shreya001
Copy link

Ok @grzesiek2010

@getodk-bot
Copy link
Member

getodk-bot commented Feb 21, 2018

Hello @sammy1997, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @opendatakit-bot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@SIMRAN1
Copy link
Contributor

SIMRAN1 commented Feb 25, 2018

@opendatakit-bot claim

@arihant-001
Copy link

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Hello @ARIHANTJAIN456, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

@isabelcosta
Copy link
Contributor

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @isabelcosta! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)
Projects
None yet
7 participants