Fixed inconsistency geopoint widgets button name

[isabelcosta]

• Closes Inconsistency between Geopoint widgets' button name #1859
• Just fixed the ternary operator logic as suggested in @lognaturel 's change label of getLocation button in geopoint widget #1928 (comment) and added a new string "Change Location".
• It lacks the translations for this new statement.

What has been done to verify that this works as intended?

I've been experimenting the Geopoint widgets, but I'm having trouble reproducing the issue problem. I picked up where the previous contributor left.
I ran the application on an emulator - Nexus 5 API 26 with Android 8.0.

Why is this the best possible solution? Were any other approaches considered?

The solution appeared to have the bug in the logic for the lack of available data. No.

Are there any risks to merging this code? If so, what are they?

There are no risks by merging this code.

Do we need any specific form for testing your changes? If so, please attach one.

I'm using All Widgets form.

[lognaturel]

Thanks, @isabelcosta! Works as expected for me. Perhaps the emulator didn't have a default value set so you were never getting a geopoint reading?

Probably no need for much verification but I'm tagging as needs testing to follow the typical QA process. No need to check more than one device/Android version

[isabelcosta]

Thanks for the review @lognaturel!
I think I got the GeoPoint reading. I got this result:

[lognaturel]

👍 The one you edited the button label for is the question before in All Widgets — geopoint with no appearance.

[mmarciniak90]

Tested with success!

Verified on Android: 4.1, 4.2, 4.4, 5.1, 6.0, 7.0, 8.0.

Verified cases:

• Adding location
• Remove response
• OSM and Google Maps

@opendatakit-bot unlabel "needs testing"
@opendatakit-bot label "behavior verified"