Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Google Analytics event for protocol on server URL change #2516

Closed
lognaturel opened this issue Sep 1, 2018 · 3 comments · Fixed by #2519
Closed

Log Google Analytics event for protocol on server URL change #2516

lognaturel opened this issue Sep 1, 2018 · 3 comments · Fixed by #2519
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)

Comments

@lognaturel
Copy link
Member

ODK Central is designed to be secure out of the box. As options for supporting HTTP or not are being considered, it would be helpful to know what the ratio of HTTP to HTTPS servers used with Collect is.

Changes to the server URL go through ServerPreferencesFragment.createChangeListener. If the URL is valid, an analytics event should be logged with category "SetServer" and an action of either "HTTP" or "HTTPS" depending on the prefix of the URL (case insensitive).

Additionally, we would like to know what servers are the same without compromising user privacy. To do this, we can log a hash of the full URL. See WidgetFactory for a similar example.
@lognaturel lognaturel added the good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =) label Sep 1, 2018
@nexusbr
Copy link
Contributor

nexusbr commented Sep 2, 2018

@opendatakit-bot claim

@getodk-bot
Copy link
Member

Welcome to Open Data Kit, @nexusbr! We just sent you an invite to collaborate on this repository at https://github.com/opendatakit/collect/invitations. Please accept this invite in order to claim this issue and begin a fun and rewarding experience contributing to Open Data Kit!

Here are some tips to get you off to a good start:

  • Please read the README.md and CONTRIBUTING.md in this repo. Those two documents have much of what you need to get started.
  • Join the ODK developer Slack to get help, chat about this issue, and meet the other developers.
  • Sign up and introduce yourself on the ODK community forum to meet the broader ODK community.

See you on the other side (that is, the pull request side)!

nexusbr added a commit to nexusbr/collect that referenced this issue Sep 2, 2018
@nexusbr
added analytics laucher to server URL change to mesure https and http…
39b77f4 
… use. close getodk#2516
@nexusbr nexusbr mentioned this issue Sep 2, 2018
Merged
3 tasks
@getodk-bot
Copy link
Member

Hello @nexusbr, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 5 days.

If you've decided to work on something else, simply comment @opendatakit-bot unclaim so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Open Data Kit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers! Experienced ODK devs, only take these if they need to be fixed quickly. =)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log Google Analytics event for protocol on server URL change nexusbr/collect
3 participants
@lognaturel @nexusbr @getodk-bot