Remove toast informing about spaces in underlying values #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of the toast we now use a well visible warning on multi select widgets. The solution is unified across all multi select widgets. This is a follow up to discussion about issue getodk#1964. Closes getodk#2284.
lognaturel
approved these changes
Jun 11, 2018
|
Tested with success! Verified on Android: 4.1, 4.2, 4.4, 5.1, 6.0, 7.0
@opendatakit-bot label "behavior verified" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning about spaces in underlying values is displayed in the question widget. There is no need for additional toast.
Closes #2284.
What has been done to verify that this works as intended?
Tested on own device. Pixel gen 1 Android 9.0 beta
Why is this the best possible solution? Were any other approaches considered?
Are there any risks to merging this code? If so, what are they?
No.
Do we need any specific form for testing your changes? If so, please attach one.
Use form provided in #1964
Before submitting this PR, please make sure you have:
./gradlew pmd checkstyle lint findbugsand confirmed all checks still pass.